diff mbox series

usb: dwc3: gadget: let pm runtime get/put paired

Message ID 20230728073919.6473-1-surong.pang@unisoc.com (mailing list archive)
State New, archived
Headers show
Series usb: dwc3: gadget: let pm runtime get/put paired | expand

Commit Message

Surong Pang July 28, 2023, 7:39 a.m. UTC
Pm_runtime_get is called when setting pending_events to true.
Pm_runtime_put is needed for pairing with pm_runtime_get.

Signed-off-by: Surong Pang <surong.pang@unisoc.com>
---
 drivers/usb/dwc3/gadget.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH July 28, 2023, 10:45 a.m. UTC | #1
On Fri, Jul 28, 2023 at 03:39:19PM +0800, Surong Pang wrote:
> Pm_runtime_get is called when setting pending_events to true.
> Pm_runtime_put is needed for pairing with pm_runtime_get.
> 
> Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> ---
>  drivers/usb/dwc3/gadget.c | 1 +
>  1 file changed, 1 insertion(+)

What commit id does this fix?

thanks,

greg k-h
surong pang July 29, 2023, 8:43 a.m. UTC | #2
Dear Greg,
The commit id is aad1a9ff2f53b8d5cde9ea07e1fd7eb7c20171ce

On Fri, Jul 28, 2023 at 6:46 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jul 28, 2023 at 03:39:19PM +0800, Surong Pang wrote:
> > Pm_runtime_get is called when setting pending_events to true.
> > Pm_runtime_put is needed for pairing with pm_runtime_get.
> >
> > Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> > ---
> >  drivers/usb/dwc3/gadget.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> What commit id does this fix?
>
> thanks,
>
> greg k-h
Greg KH July 30, 2023, 11:24 a.m. UTC | #3
On Sat, Jul 29, 2023 at 04:43:13PM +0800, surong pang wrote:
> Dear Greg,
> The commit id is aad1a9ff2f53b8d5cde9ea07e1fd7eb7c20171ce

Wonderful, please resend with the proper Fixes: tag in the patch and we
will be glad to queue it up.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 5fd067151fbf..9c835c5f9928 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4720,5 +4720,6 @@  void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
 		dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
 		dwc->pending_events = false;
 		enable_irq(dwc->irq_gadget);
+		pm_runtime_put(dwc->dev);
 	}
 }