diff mbox series

usb: dwc3: gadget: Let pm runtime get/put paired

Message ID 20230801005651.29863-1-surong.pang@unisoc.com (mailing list archive)
State Superseded
Headers show
Series usb: dwc3: gadget: Let pm runtime get/put paired | expand

Commit Message

Surong Pang Aug. 1, 2023, 12:56 a.m. UTC
Pm_runtime_get is called when setting pending_events to true.
Pm_runtime_put is needed for pairing with pm_runtime_get.

Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
Signed-off-by: Surong Pang <surong.pang@unisoc.com>
---
 drivers/usb/dwc3/gadget.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thinh Nguyen Aug. 1, 2023, 1:06 a.m. UTC | #1
On Tue, Aug 01, 2023, Surong Pang wrote:
> Pm_runtime_get is called when setting pending_events to true.
> Pm_runtime_put is needed for pairing with pm_runtime_get.
> 
> Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> ---
>  drivers/usb/dwc3/gadget.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 5fd067151fbf..9c835c5f9928 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
>  		dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
>  		dwc->pending_events = false;
>  		enable_irq(dwc->irq_gadget);
> +		pm_runtime_put(dwc->dev);
>  	}
>  }
> -- 
> 2.17.1
> 

You need to properly increment the patch version every new submission
and note what are the new changes. Otherwise Greg won't know which patch
to pick up. Please resubmit at least v2 with note of the changes.

Thanks,
Thinh
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 5fd067151fbf..9c835c5f9928 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4720,5 +4720,6 @@  void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
 		dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
 		dwc->pending_events = false;
 		enable_irq(dwc->irq_gadget);
+		pm_runtime_put(dwc->dev);
 	}
 }