| Message ID | 20230803032838.3045730-1-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 98d6db05eda86ce50c84dcf29dcc9de0e9f8f140 |
| Headers | show |
| Series | [-next] usb: gadget: udc: Remove redundant initialization for udc_driver | expand |
Hi Li, On Thu, 3 Aug 2023 11:28:38 +0800 Li Zetao <lizetao1@huawei.com> wrote: > There is a warning reported by coccinelle: > > ./drivers/usb/gadget/udc/renesas_usbf.c:3381:3-8: > No need to set .owner here. The core will do it. > > The module_platform_driver() will set "THIS_MODULE" to driver.owner > when register a driver for platform-level devices, so it is redundant > initialization to set driver.owner in udc_driver statement. Remove it > to silence the warning. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> > --- > drivers/usb/gadget/udc/renesas_usbf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c > index 3482b41d0646..657f265ac7cc 100644 > --- a/drivers/usb/gadget/udc/renesas_usbf.c > +++ b/drivers/usb/gadget/udc/renesas_usbf.c > @@ -3378,7 +3378,6 @@ MODULE_DEVICE_TABLE(of, usbf_match); > static struct platform_driver udc_driver = { > .driver = { > .name = "usbf_renesas", > - .owner = THIS_MODULE, > .of_match_table = usbf_match, > }, > .probe = usbf_probe, Acked-by: Herve Codina <herve.codina@bootlin.com> Thanks, Hervé
diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c index 3482b41d0646..657f265ac7cc 100644 --- a/drivers/usb/gadget/udc/renesas_usbf.c +++ b/drivers/usb/gadget/udc/renesas_usbf.c @@ -3378,7 +3378,6 @@ MODULE_DEVICE_TABLE(of, usbf_match); static struct platform_driver udc_driver = { .driver = { .name = "usbf_renesas", - .owner = THIS_MODULE, .of_match_table = usbf_match, }, .probe = usbf_probe,
There is a warning reported by coccinelle: ./drivers/usb/gadget/udc/renesas_usbf.c:3381:3-8: No need to set .owner here. The core will do it. The module_platform_driver() will set "THIS_MODULE" to driver.owner when register a driver for platform-level devices, so it is redundant initialization to set driver.owner in udc_driver statement. Remove it to silence the warning. Signed-off-by: Li Zetao <lizetao1@huawei.com> --- drivers/usb/gadget/udc/renesas_usbf.c | 1 - 1 file changed, 1 deletion(-)