| Message ID | 20230903214150.2877023-8-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm,usb/typec: uABI for USB-C DisplayPort connectors | expand |
On Mon, Sep 04, 2023 at 12:41:45AM +0300, Dmitry Baryshkov wrote: > Set the bridge's path property to point out that this connector is > wrapped into the Type-C port. > > We can not really identify the exact Type-C port because it is > registered separately, by another driver, which is not mandatory and the > corresponding device is not even present on some of platforms, like > sc8180x or sm8350. Thus we use the shortened version of the PATH, which > includes just the 'typec:' part. How would a properly resolved path look like? As with the other patch, I'm okay with this going through the USB tree. Acked-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn
On 04/09/2023 18:43, Bjorn Andersson wrote: > On Mon, Sep 04, 2023 at 12:41:45AM +0300, Dmitry Baryshkov wrote: >> Set the bridge's path property to point out that this connector is >> wrapped into the Type-C port. >> >> We can not really identify the exact Type-C port because it is >> registered separately, by another driver, which is not mandatory and the >> corresponding device is not even present on some of platforms, like >> sc8180x or sm8350. Thus we use the shortened version of the PATH, which >> includes just the 'typec:' part. > > How would a properly resolved path look like? On RB5 it is 'typec:port0', as the USB-C port is registered as /sys/class/typec/port0 > > As with the other patch, I'm okay with this going through the USB tree. > > Acked-by: Bjorn Andersson <andersson@kernel.org> > > Regards, > Bjorn
diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c index 974c14d1e0bf..a5b72046caaa 100644 --- a/drivers/soc/qcom/pmic_glink_altmode.c +++ b/drivers/soc/qcom/pmic_glink_altmode.c @@ -466,6 +466,7 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev, alt_port->bridge.of_node = to_of_node(fwnode); alt_port->bridge.ops = DRM_BRIDGE_OP_HPD; alt_port->bridge.type = DRM_MODE_CONNECTOR_DisplayPort; + alt_port->bridge.path = "typec:"; ret = devm_drm_bridge_add(dev, &alt_port->bridge); if (ret)
Set the bridge's path property to point out that this connector is wrapped into the Type-C port. We can not really identify the exact Type-C port because it is registered separately, by another driver, which is not mandatory and the corresponding device is not even present on some of platforms, like sc8180x or sm8350. Thus we use the shortened version of the PATH, which includes just the 'typec:' part. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/soc/qcom/pmic_glink_altmode.c | 1 + 1 file changed, 1 insertion(+)