| Message ID | 20230912-topic-tps6598x_reset-v1-2-78dc0bf61790@wolfvision.net (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: tps6598x: add reset gpio support | expand |
On 15/09/2023 08:50, Javier Carrasco wrote: > The TPS6598x driver supports an optional high-level reset GPIO. What driver supports or not, it does not matter. The question is (and commit msg should say) whether hardware has such reset pin or not. > Document the new property and add it to the example. > > Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> > --- > Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > index 5497a60cddbc..b1a621e06127 100644 > --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml > @@ -23,6 +23,10 @@ properties: > reg: > maxItems: 1 > > + reset-gpios: > + description: GPIO used for the HRESET pin. This probably answers that yes - it is a pin in hardware... Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml index 5497a60cddbc..b1a621e06127 100644 --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml @@ -23,6 +23,10 @@ properties: reg: maxItems: 1 + reset-gpios: + description: GPIO used for the HRESET pin. + maxItems: 1 + wakeup-source: true interrupts: @@ -40,6 +44,7 @@ additionalProperties: true examples: - | + #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> i2c { #address-cells = <1>; @@ -56,6 +61,7 @@ examples: pinctrl-names = "default"; pinctrl-0 = <&typec_pins>; + reset-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>; typec_con: connector { compatible = "usb-c-connector";
The TPS6598x driver supports an optional high-level reset GPIO. Document the new property and add it to the example. Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> --- Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 6 ++++++ 1 file changed, 6 insertions(+)