| Message ID | 20230927123511.45085-2-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5220d8b04a840fa09434072c866d032b163419e3 |
| Headers | show |
| Series | [v3,1/2] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 | expand |
On Wed, Sep 27, 2023 at 09:35:11AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is > no mode-switch, only an orientation switch. > > Make the 'mode-switch' property a non-required one. There seem to be very few compatibles in this file, so I guess everything uses the generic compatible. I'm not expecting you to know why it's like this, but should we add a compatible for this particular mux & only relax the requirement for it specifically? > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v2: > - Newly introduced. > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > index b61dcf8b4aad..d3b2b666ec2a 100644 > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > @@ -51,7 +51,6 @@ required: > - compatible > - enable-gpios > - select-gpios > - - mode-switch > - orientation-switch > - port > > -- > 2.34.1 >
Hi Conor, On Thu, Sep 28, 2023 at 2:04 PM Conor Dooley <conor@kernel.org> wrote: > > On Wed, Sep 27, 2023 at 09:35:11AM -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@denx.de> > > > > On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is > > no mode-switch, only an orientation switch. > > > > Make the 'mode-switch' property a non-required one. > > There seem to be very few compatibles in this file, so I guess > everything uses the generic compatible. I'm not expecting you to know > why it's like this, but should we add a compatible for this particular > mux & only relax the requirement for it specifically? I am not sure. Bjorn, do you have any suggestions, please? > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > --- > > Changes since v2: > > - Newly introduced. > > > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > index b61dcf8b4aad..d3b2b666ec2a 100644 > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > @@ -51,7 +51,6 @@ required: > > - compatible > > - enable-gpios > > - select-gpios > > - - mode-switch > > - orientation-switch > > - port > > > > -- > > 2.34.1 > >
On Fri, Sep 29, 2023 at 03:41:58PM -0300, Fabio Estevam wrote: > Hi Conor, > > On Thu, Sep 28, 2023 at 2:04 PM Conor Dooley <conor@kernel.org> wrote: > > > > On Wed, Sep 27, 2023 at 09:35:11AM -0300, Fabio Estevam wrote: > > > From: Fabio Estevam <festevam@denx.de> > > > > > > On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is > > > no mode-switch, only an orientation switch. > > > > > > Make the 'mode-switch' property a non-required one. > > > > There seem to be very few compatibles in this file, so I guess > > everything uses the generic compatible. I'm not expecting you to know > > why it's like this, but should we add a compatible for this particular > > mux & only relax the requirement for it specifically? > > I am not sure. > > Bjorn, do you have any suggestions, please? FWIW, Acked-by: Conor Dooley <conor.dooley@microchip.com> although I do think that adding more compatibles if there is gonna be divergence in capabilities is a good idea.. Cheers, Conor. > > > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > > --- > > > Changes since v2: > > > - Newly introduced. > > > > > > Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > index b61dcf8b4aad..d3b2b666ec2a 100644 > > > --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml > > > @@ -51,7 +51,6 @@ required: > > > - compatible > > > - enable-gpios > > > - select-gpios > > > - - mode-switch > > > - orientation-switch > > > - port > > > > > > -- > > > 2.34.1 > > >
diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml index b61dcf8b4aad..d3b2b666ec2a 100644 --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml @@ -51,7 +51,6 @@ required: - compatible - enable-gpios - select-gpios - - mode-switch - orientation-switch - port