| Message ID | 20230930203646.61863-1-bergh.jonathan@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] drivers: usb: Fix block comments whose trailing */ was not on a separate line | expand |
On Sat, Sep 30, 2023 at 10:36:46PM +0200, Jonathan Bergh wrote: > Fixed various instances where block comments trailing */ where not on a > separate line and should be. > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> > --- > drivers/usb/atm/cxacru.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) Your subject line for these patches is not correct, please fix up. And the patches are not properly threaded, what happened in your email client? And finally, why make coding style changes outside of drivers/staging/? Did you get the maintainer's approval to do so before taking the time? Usually most maintainers do not want these so always ask before doing so, or just stick with drivers/staging/ to learn how the process works first please. thanks, greg k-h
On Sun, Oct 01, 2023 at 08:06:06AM +0200, Greg KH wrote: > On Sat, Sep 30, 2023 at 10:36:46PM +0200, Jonathan Bergh wrote: > > Fixed various instances where block comments trailing */ where not on a > > separate line and should be. > > > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> > > --- > > drivers/usb/atm/cxacru.c | 12 ++++++++---- > > 1 file changed, 8 insertions(+), 4 deletions(-) Hi Greg, thanks a lot > Your subject line for these patches is not correct, please fix up. Thanks, will do. > And the patches are not properly threaded, what happened in your email > client? Ok thanks, I used the same process as last time but will check it out. > And finally, why make coding style changes outside of drivers/staging/? > Did you get the maintainer's approval to do so before taking the time? > Usually most maintainers do not want these so always ask before doing > so, or just stick with drivers/staging/ to learn how the process works > first please. Ok! Thanks! Would you like these patches? I'd be happy to resend them. Hopefully (like the guy you mentioned in your talk) unless they screw something up, are seen as making a (postive) contribution! cheers! jon > thanks, > > greg k-h
diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c index 4ce7cba2b48a..ba795a8d3888 100644 --- a/drivers/usb/atm/cxacru.c +++ b/drivers/usb/atm/cxacru.c @@ -55,7 +55,8 @@ static const char cxacru_driver_name[] = "cxacru"; #define POLL_INTERVAL 1 /* secs */ /* commands for interaction with the modem through the control channel before - * firmware is loaded */ + * firmware is loaded + */ enum cxacru_fw_request { FW_CMD_ERR, FW_GET_VER, @@ -67,7 +68,8 @@ enum cxacru_fw_request { }; /* commands for interaction with the modem through the control channel once - * firmware is loaded */ + * firmware is loaded + */ enum cxacru_cm_request { CM_REQUEST_UNDEFINED = 0x80, CM_REQUEST_TEST, @@ -369,7 +371,8 @@ static ssize_t adsl_state_store(struct device *dev, /* Line status is only updated every second * and the device appears to only react to * START/STOP every second too. Wait 1.5s to - * be sure that restart will have an effect. */ + * be sure that restart will have an effect. + */ if (!strcmp(str_cmd, "restart")) msleep(1500); @@ -1237,7 +1240,8 @@ static void cxacru_unbind(struct usbatm_data *usbatm_instance, BUG_ON(instance->poll_state == CXPOLL_SHUTDOWN); /* ensure that status polling continues unless - * it has already stopped */ + * it has already stopped + */ if (instance->poll_state == CXPOLL_STOPPED) is_polling = 0;
Fixed various instances where block comments trailing */ where not on a separate line and should be. Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> --- drivers/usb/atm/cxacru.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)