| Message ID | 20231002161610.2648818-10-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,01/10] xhci: dbc: Drop duplicate checks for dma_free_coherent() | expand |
On 2.10.2023 19.16, Andy Shevchenko wrote: > Don't inherit headers "by chances" from asm/bug.h, asm/io.h, > etc... Include the needed headers explicitly. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/usb/host/xhci-dbgcap.c | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c > index 366ce3146a93..eb2e89bf31be 100644 > --- a/drivers/usb/host/xhci-dbgcap.c > +++ b/drivers/usb/host/xhci-dbgcap.c > @@ -6,9 +6,24 @@ > * > * Author: Lu Baolu <baolu.lu@linux.intel.com> > */ > +#include <linux/device.h> > #include <linux/dma-mapping.h> > -#include <linux/slab.h> > +#include <linux/errno.h> > +#include <linux/kstrtox.h> > +#include <linux/list.h> > #include <linux/nls.h> > +#include <linux/pm_runtime.h> > +#include <linux/slab.h> > +#include <linux/spinlock.h> > +#include <linux/string.h> > +#include <linux/sysfs.h> > +#include <linux/types.h> > +#include <linux/workqueue.h> > + > +#include <linux/io-64-nonatomic-lo-hi.h> > + > +#include <asm/bug.h> > +#include <asm/byteorder.h> Checkpatch complains about this: WARNING: Use #include <linux/bug.h> instead of <asm/bug.h> -Mathias
diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c index 366ce3146a93..eb2e89bf31be 100644 --- a/drivers/usb/host/xhci-dbgcap.c +++ b/drivers/usb/host/xhci-dbgcap.c @@ -6,9 +6,24 @@ * * Author: Lu Baolu <baolu.lu@linux.intel.com> */ +#include <linux/device.h> #include <linux/dma-mapping.h> -#include <linux/slab.h> +#include <linux/errno.h> +#include <linux/kstrtox.h> +#include <linux/list.h> #include <linux/nls.h> +#include <linux/pm_runtime.h> +#include <linux/slab.h> +#include <linux/spinlock.h> +#include <linux/string.h> +#include <linux/sysfs.h> +#include <linux/types.h> +#include <linux/workqueue.h> + +#include <linux/io-64-nonatomic-lo-hi.h> + +#include <asm/bug.h> +#include <asm/byteorder.h> #include "xhci.h" #include "xhci-trace.h"
Don't inherit headers "by chances" from asm/bug.h, asm/io.h, etc... Include the needed headers explicitly. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/usb/host/xhci-dbgcap.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)