| Message ID | 20231019183015.841460-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cf36d7db25b625e03d363cf8e59114d0f1ff68aa |
| Headers | show |
| Series | usb: chipidea: Fix unused ci_hdrc_usb2_of_match warning for !CONFIG_OF | expand |
On 23-10-19 13:30:15, Rob Herring wrote: > Commit 14485de431b0 ("usb: Use device_get_match_data()") dropped the > unconditional use of ci_hdrc_usb2_of_match resulting in this warning: > > drivers/usb/chipidea/ci_hdrc_usb2.c:41:34: warning: unused variable 'ci_hdrc_usb2_of_match' [-Wunused-const-variable] > > The fix is to drop of_match_ptr() which is not necessary because DT is > always used for this driver. > > Fixes: 14485de431b0 ("usb: Use device_get_match_data()") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202310131627.M43j234A-lkp@intel.com/ > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Peter Chen <peter.chen@kernel.org> > --- > drivers/usb/chipidea/ci_hdrc_usb2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c > index 180a632dd7ba..97379f653b06 100644 > --- a/drivers/usb/chipidea/ci_hdrc_usb2.c > +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c > @@ -119,7 +119,7 @@ static struct platform_driver ci_hdrc_usb2_driver = { > .remove_new = ci_hdrc_usb2_remove, > .driver = { > .name = "chipidea-usb2", > - .of_match_table = of_match_ptr(ci_hdrc_usb2_of_match), > + .of_match_table = ci_hdrc_usb2_of_match, > }, > }; > module_platform_driver(ci_hdrc_usb2_driver); > -- > 2.42.0 >
diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c index 180a632dd7ba..97379f653b06 100644 --- a/drivers/usb/chipidea/ci_hdrc_usb2.c +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c @@ -119,7 +119,7 @@ static struct platform_driver ci_hdrc_usb2_driver = { .remove_new = ci_hdrc_usb2_remove, .driver = { .name = "chipidea-usb2", - .of_match_table = of_match_ptr(ci_hdrc_usb2_of_match), + .of_match_table = ci_hdrc_usb2_of_match, }, }; module_platform_driver(ci_hdrc_usb2_driver);
Commit 14485de431b0 ("usb: Use device_get_match_data()") dropped the unconditional use of ci_hdrc_usb2_of_match resulting in this warning: drivers/usb/chipidea/ci_hdrc_usb2.c:41:34: warning: unused variable 'ci_hdrc_usb2_of_match' [-Wunused-const-variable] The fix is to drop of_match_ptr() which is not necessary because DT is always used for this driver. Fixes: 14485de431b0 ("usb: Use device_get_match_data()") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202310131627.M43j234A-lkp@intel.com/ Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/usb/chipidea/ci_hdrc_usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)