| Message ID | 20231031044021.1162403-3-mnkumar@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add a quirk in xhci-plat for parent nodes to specify no 64 bit support | expand |
On Tue, Oct 31, 2023 at 04:40:21AM +0000, Naveen Kumar wrote: > From: Naveen Kumar M <mnkumar@google.com> > > Add a new DT option to specify whether a host controller is able to > support 64-bit DMA memory pointers > > Signed-off-by: Naveen Kumar M <mnkumar@google.com> > --- > Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.yaml b/Documentation/devicetree/bindings/usb/usb-xhci.yaml > index 180a261c3e8f..20dc134004f3 100644 > --- a/Documentation/devicetree/bindings/usb/usb-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.yaml > @@ -25,6 +25,10 @@ properties: > description: Set if the controller has broken port disable mechanism > type: boolean > > + quirk-no-64-bit-support: > + description: Set if the xHC doesn't support 64-bit DMA memory pointers > + type: boolean > + > imod-interval-ns: > description: Interrupt moderation interval > default: 5000 > -- > 2.42.0.820.g83a721a137-goog > > You did not send this patch to all of the relevant maintainers/reviewers, why not? please always use scripts/get_maintainer.pl on your patches. thanks, greg k-h
On 31/10/2023 05:40, Naveen Kumar wrote: > From: Naveen Kumar M <mnkumar@google.com> > > Add a new DT option to specify whether a host controller is able to > support 64-bit DMA memory pointers > > Signed-off-by: Naveen Kumar M <mnkumar@google.com> > --- > Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++ Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
Apologies for sending without plain text mode in the previous mail. Adding the reviewers/maintainers I missed in the initial mail to this patch On Wed, Nov 1, 2023 at 9:50 AM Naveen Kumar M <mnkumar@google.com> wrote: > > Adding the reviewers/maintainers I missed in the previous mail to this patch > > On Tue, Oct 31, 2023 at 10:11 AM Naveen Kumar <mnkumar@google.com> wrote: >> >> From: Naveen Kumar M <mnkumar@google.com> >> >> Add a new DT option to specify whether a host controller is able to >> support 64-bit DMA memory pointers >> >> Signed-off-by: Naveen Kumar M <mnkumar@google.com> >> --- >> Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.yaml b/Documentation/devicetree/bindings/usb/usb-xhci.yaml >> index 180a261c3e8f..20dc134004f3 100644 >> --- a/Documentation/devicetree/bindings/usb/usb-xhci.yaml >> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.yaml >> @@ -25,6 +25,10 @@ properties: >> description: Set if the controller has broken port disable mechanism >> type: boolean >> >> + quirk-no-64-bit-support: >> + description: Set if the xHC doesn't support 64-bit DMA memory pointers >> + type: boolean >> + >> imod-interval-ns: >> description: Interrupt moderation interval >> default: 5000 >> -- >> 2.42.0.820.g83a721a137-goog >>
On 01/11/2023 05:20, Naveen Kumar M wrote:
> Adding the reviewers/maintainers I missed in the previous mail to this patch
Nope, it does not work like this.
1. I don't have the patch in mailbox.
2. How can I be sure it was even tested by automation?
I won't be reviewing it. Follow Linux kernel submission process.
Best regards,
Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.yaml b/Documentation/devicetree/bindings/usb/usb-xhci.yaml index 180a261c3e8f..20dc134004f3 100644 --- a/Documentation/devicetree/bindings/usb/usb-xhci.yaml +++ b/Documentation/devicetree/bindings/usb/usb-xhci.yaml @@ -25,6 +25,10 @@ properties: description: Set if the controller has broken port disable mechanism type: boolean + quirk-no-64-bit-support: + description: Set if the xHC doesn't support 64-bit DMA memory pointers + type: boolean + imod-interval-ns: description: Interrupt moderation interval default: 5000