| Message ID | 20231108125843.3806765-17-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 48d584b7f90f48d2623fb01743b099efbf0d36c2 |
| Headers | show |
| Series | -Wmissing-prototype warning fixes | expand |
On Wed, Nov 08, 2023 at 01:58:37PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > bch2_target_to_text_sb() is only called in the file it is defined in, > and it has no extern prototype: > > fs/bcachefs/disk_groups.c:583:6: error: no previous prototype for 'bch2_target_to_text_sb' [-Werror=missing-prototypes] > > Mark it static to avoid the warning and have the code better optimized. > > Fixes: bf0d9e89de2e ("bcachefs: Split apart bch2_target_to_text(), bch2_target_to_text_sb()") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> This is already fixed in my tree.
diff --git a/fs/bcachefs/disk_groups.c b/fs/bcachefs/disk_groups.c index d613695abf9f..1f334124055b 100644 --- a/fs/bcachefs/disk_groups.c +++ b/fs/bcachefs/disk_groups.c @@ -580,7 +580,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v) } } -void bch2_target_to_text_sb(struct printbuf *out, struct bch_sb *sb, unsigned v) +static void bch2_target_to_text_sb(struct printbuf *out, struct bch_sb *sb, unsigned v) { struct target t = target_decode(v);