| Message ID | 20231120091046.163781-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2a9c713825b3127ece11984abf973672c9779518 |
| Headers | show |
| Series | phy: sunplus: return negative error code in sp_usb_phy_probe | expand |
On Mon, 20 Nov 2023 17:10:47 +0800, Su Hui wrote: > devm_phy_create() return negative error code, 'ret' should be > 'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'. > > Applied, thanks! [1/1] phy: sunplus: return negative error code in sp_usb_phy_probe commit: 2a9c713825b3127ece11984abf973672c9779518 Best regards,
diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c index 0efe74ac9c6a..637a5fbae6d9 100644 --- a/drivers/phy/sunplus/phy-sunplus-usb2.c +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c @@ -275,7 +275,7 @@ static int sp_usb_phy_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &sp_uphy_ops); if (IS_ERR(phy)) { - ret = -PTR_ERR(phy); + ret = PTR_ERR(phy); return ret; }
devm_phy_create() return negative error code, 'ret' should be 'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'. Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021") Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/phy/sunplus/phy-sunplus-usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)