| Message ID | 20231121092258.9334-10-jirislaby@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e4b3cd3b6a0d79857d561af999451fc958457dee |
| Headers | show |
| Series | tty: small cleanups and fixes | expand |
On Tue, 21 Nov 2023 10:22:50 +0100 Jiri Slaby (SUSE) wrote: > It's preferred NOT to emit anything during the module load and unload > (in case the un/load was successful). So drop these prints from hso > along with global 'version'. It even contains no version after all. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Eric Dumazet <edumazet@google.com> > Cc: Jakub Kicinski <kuba@kernel.org> Acked-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 83b8452220ec..48450fe861ad 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -363,7 +363,6 @@ static int disable_net; /* driver info */ static const char driver_name[] = "hso"; static const char tty_filename[] = "ttyHS"; -static const char *version = __FILE__ ": " MOD_AUTHOR; /* the usb driver itself (registered in hso_init) */ static struct usb_driver hso_driver; /* serial structures */ @@ -3231,9 +3230,6 @@ static int __init hso_init(void) int i; int result; - /* put it in the log */ - pr_info("%s\n", version); - /* Initialise the serial table semaphore and table */ for (i = 0; i < HSO_SERIAL_TTY_MINORS; i++) serial_table[i] = NULL; @@ -3285,8 +3281,6 @@ static int __init hso_init(void) static void __exit hso_exit(void) { - pr_info("unloaded\n"); - tty_unregister_driver(tty_drv); /* deregister the usb driver */ usb_deregister(&hso_driver);
It's preferred NOT to emit anything during the module load and unload (in case the un/load was successful). So drop these prints from hso along with global 'version'. It even contains no version after all. Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: linux-usb@vger.kernel.org Cc: netdev@vger.kernel.org --- drivers/net/usb/hso.c | 6 ------ 1 file changed, 6 deletions(-)