| Message ID | 20231122141803.82844-1-SpriteOvO@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | da90e45d5afc4da2de7cd3ea7943d0f1baa47cc2 |
| Headers | show |
| Series | [v2] USB: serial: option: add Luat Air72*U series products | expand |
Compared to v1, the v2 patch only changed the git name. Thanks, On 11/22/23 22:18, Asuna Yang wrote: > Update the USB serial option driver support for Luat Air72*U series > products. > > ID 1782:4e00 Spreadtrum Communications Inc. UNISOC-8910 > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 13 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=1782 ProdID=4e00 Rev=00.00 > S: Manufacturer=UNISOC > S: Product=UNISOC-8910 > C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=400mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=e0(wlcon) Sub=01 Prot=03 Driver=rndis_host > E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=4096ms > I: If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I: If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I: If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > Co-developed-by: Yangyu Chen <cyy@cyyself.name> > Signed-off-by: Yangyu Chen <cyy@cyyself.name> > Signed-off-by: Asuna Yang <SpriteOvO@gmail.com> > --- > drivers/usb/serial/option.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 45dcfaadaf98..b76cb9a096f7 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -609,6 +609,8 @@ static void option_instat_callback(struct urb *urb); > #define UNISOC_VENDOR_ID 0x1782 > /* TOZED LT70-C based on UNISOC SL8563 uses UNISOC's vendor ID */ > #define TOZED_PRODUCT_LT70C 0x4055 > +/* Luat Air72*U series based on UNISOC UIS8910 uses UNISOC's vendor ID */ > +#define LUAT_PRODUCT_AIR720U 0x4e00 > > /* Device flags */ > > @@ -2271,6 +2273,7 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0xff, 0x40) }, > { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0, 0) }, > { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C, 0xff, 0, 0) }, > + { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, LUAT_PRODUCT_AIR720U, 0xff, 0, 0) }, > { } /* Terminating entry */ > }; > MODULE_DEVICE_TABLE(usb, option_ids);
On Wed, Nov 22, 2023 at 10:18:03PM +0800, Asuna Yang wrote: > Update the USB serial option driver support for Luat Air72*U series > products. > > ID 1782:4e00 Spreadtrum Communications Inc. UNISOC-8910 > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 13 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=1782 ProdID=4e00 Rev=00.00 > S: Manufacturer=UNISOC > S: Product=UNISOC-8910 > C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=400mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=e0(wlcon) Sub=01 Prot=03 Driver=rndis_host > E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=4096ms > I: If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I: If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I: If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > Co-developed-by: Yangyu Chen <cyy@cyyself.name> > Signed-off-by: Yangyu Chen <cyy@cyyself.name> > Signed-off-by: Asuna Yang <SpriteOvO@gmail.com> Thanks for the v2. Can you say something about what the three serial interfaces are used for (and which is which)? Johan
If#= 2: AT If#= 3: PPP + AT If#= 4: Debug Reference from the device documentation: https://doc.openluat.com/wiki/21?wiki_page_id=2501 Should I send a v3 to include the serial interfaces information in the git message? This is my first time sending a patch to the kernel, please forgive me for not being particularly sure of the process. Thanks, On 11/23/23 20:11, Johan Hovold wrote: > On Wed, Nov 22, 2023 at 10:18:03PM +0800, Asuna Yang wrote: >> Update the USB serial option driver support for Luat Air72*U series >> products. >> >> ID 1782:4e00 Spreadtrum Communications Inc. UNISOC-8910 >> >> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 13 Spd=480 MxCh= 0 >> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 >> P: Vendor=1782 ProdID=4e00 Rev=00.00 >> S: Manufacturer=UNISOC >> S: Product=UNISOC-8910 >> C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=400mA >> I: If#= 0 Alt= 0 #EPs= 1 Cls=e0(wlcon) Sub=01 Prot=03 Driver=rndis_host >> E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=4096ms >> I: If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host >> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> I: If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> I: If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option >> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms >> >> Co-developed-by: Yangyu Chen <cyy@cyyself.name> >> Signed-off-by: Yangyu Chen <cyy@cyyself.name> >> Signed-off-by: Asuna Yang <SpriteOvO@gmail.com> > Thanks for the v2. > > Can you say something about what the three serial interfaces are used > for (and which is which)? > > Johan
On Fri, Nov 24, 2023 at 01:03:46AM +0800, Asuna Yang wrote: > If#= 2: AT > If#= 3: PPP + AT > If#= 4: Debug > > Reference from the device documentation: > https://doc.openluat.com/wiki/21?wiki_page_id=2501 Thanks for the details. > Should I send a v3 to include the serial interfaces information in the > git message? This is my first time sending a patch to the kernel, please > forgive me for not being particularly sure of the process. No, that's ok, I can just amend the commit message when applying. For your next contribution, just keep in mind that top-posting should be avoided when replying on the mailing lists (instead reply inline after trimming unnecessary context as I did here). And congratulations on your first merged kernel patch. :) Johan
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 45dcfaadaf98..b76cb9a096f7 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -609,6 +609,8 @@ static void option_instat_callback(struct urb *urb); #define UNISOC_VENDOR_ID 0x1782 /* TOZED LT70-C based on UNISOC SL8563 uses UNISOC's vendor ID */ #define TOZED_PRODUCT_LT70C 0x4055 +/* Luat Air72*U series based on UNISOC UIS8910 uses UNISOC's vendor ID */ +#define LUAT_PRODUCT_AIR720U 0x4e00 /* Device flags */ @@ -2271,6 +2273,7 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0xff, 0x40) }, { USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0, 0) }, { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C, 0xff, 0, 0) }, + { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, LUAT_PRODUCT_AIR720U, 0xff, 0, 0) }, { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, option_ids);