| Message ID | 20231123063417.2625808-1-u202112004@hust.edu.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | usb: storage: transport: Fix switch-case indentation typo in 'transport.c' | expand |
On Thu, Nov 23, 2023 at 01:34:16AM -0500, Ren Xiao wrote: > Adjusted the indentation of the switch-case code blocks which > start from line 1051 and line 1304. > > Signed-off-by: Ren Xiao <u202112004@hust.edu.cn> > Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> > --- > drivers/usb/storage/transport.c | 46 ++++++++++++++++----------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c index 8f236854c83b..88d9f839d809 100644 --- a/drivers/usb/storage/transport.c +++ b/drivers/usb/storage/transport.c @@ -1049,10 +1049,10 @@ int usb_stor_CB_transport(struct scsi_cmnd *srb, struct us_data *us) /* The second byte & 0x0F should be 0x0 for good, otherwise error */ switch (us->iobuf[1] & 0x0F) { - case 0x00: - return USB_STOR_TRANSPORT_GOOD; - case 0x01: - goto Failed; + case 0x00: + return USB_STOR_TRANSPORT_GOOD; + case 0x01: + goto Failed; } return USB_STOR_TRANSPORT_ERROR; @@ -1302,28 +1302,28 @@ int usb_stor_Bulk_transport(struct scsi_cmnd *srb, struct us_data *us) /* based on the status code, we report good or bad */ switch (bcs->Status) { - case US_BULK_STAT_OK: - /* device babbled -- return fake sense data */ - if (fake_sense) { - memcpy(srb->sense_buffer, - usb_stor_sense_invalidCDB, - sizeof(usb_stor_sense_invalidCDB)); - return USB_STOR_TRANSPORT_NO_SENSE; - } + case US_BULK_STAT_OK: + /* device babbled -- return fake sense data */ + if (fake_sense) { + memcpy(srb->sense_buffer, + usb_stor_sense_invalidCDB, + sizeof(usb_stor_sense_invalidCDB)); + return USB_STOR_TRANSPORT_NO_SENSE; + } - /* command good -- note that data could be short */ - return USB_STOR_TRANSPORT_GOOD; + /* command good -- note that data could be short */ + return USB_STOR_TRANSPORT_GOOD; - case US_BULK_STAT_FAIL: - /* command failed */ - return USB_STOR_TRANSPORT_FAILED; + case US_BULK_STAT_FAIL: + /* command failed */ + return USB_STOR_TRANSPORT_FAILED; - case US_BULK_STAT_PHASE: - /* - * phase error -- note that a transport reset will be - * invoked by the invoke_transport() function - */ - return USB_STOR_TRANSPORT_ERROR; + case US_BULK_STAT_PHASE: + /* + * phase error -- note that a transport reset will be + * invoked by the invoke_transport() function + */ + return USB_STOR_TRANSPORT_ERROR; } /* we should never get here, but if we do, we're in trouble */