| Message ID | 20231127111332.107640-1-frieder@fris.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] usb: misc: onboard_usb_hub: Print symbolic error names | expand |
Sorry, forgot to add the correct version prefix v2 in this series. I will resend. On 27.11.23 12:13, Frieder Schrempf wrote: > From: Frieder Schrempf <frieder.schrempf@kontron.de> > > Instead of printing the decimal error codes, let's use the more > human-readable symbolic error names provided by the %pe printk > format specifier. > > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > Changes in v2: > * new patch > --- > drivers/usb/misc/onboard_usb_hub.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c > index a341b2fbb7b44..077824beffa01 100644 > --- a/drivers/usb/misc/onboard_usb_hub.c > +++ b/drivers/usb/misc/onboard_usb_hub.c > @@ -7,6 +7,7 @@ > > #include <linux/device.h> > #include <linux/export.h> > +#include <linux/err.h> > #include <linux/gpio/consumer.h> > #include <linux/init.h> > #include <linux/kernel.h> > @@ -68,7 +69,7 @@ static int onboard_hub_power_on(struct onboard_hub *hub) > > err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies); > if (err) { > - dev_err(hub->dev, "failed to enable supplies: %d\n", err); > + dev_err(hub->dev, "failed to enable supplies: %pe\n", ERR_PTR(err)); > return err; > } > > @@ -88,7 +89,7 @@ static int onboard_hub_power_off(struct onboard_hub *hub) > > err = regulator_bulk_disable(hub->pdata->num_supplies, hub->supplies); > if (err) { > - dev_err(hub->dev, "failed to disable supplies: %d\n", err); > + dev_err(hub->dev, "failed to disable supplies: %pe\n", ERR_PTR(err)); > return err; > } > > @@ -235,7 +236,7 @@ static void onboard_hub_attach_usb_driver(struct work_struct *work) > > err = driver_attach(&onboard_hub_usbdev_driver.drvwrap.driver); > if (err) > - pr_err("Failed to attach USB driver: %d\n", err); > + pr_err("Failed to attach USB driver: %pe\n", ERR_PTR(err)); > } > > static int onboard_hub_probe(struct platform_device *pdev) > @@ -262,7 +263,7 @@ static int onboard_hub_probe(struct platform_device *pdev) > > err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies); > if (err) { > - dev_err(dev, "Failed to get regulator supplies: %d\n", err); > + dev_err(dev, "Failed to get regulator supplies: %pe\n", ERR_PTR(err)); > return err; > } >
diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index a341b2fbb7b44..077824beffa01 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -7,6 +7,7 @@ #include <linux/device.h> #include <linux/export.h> +#include <linux/err.h> #include <linux/gpio/consumer.h> #include <linux/init.h> #include <linux/kernel.h> @@ -68,7 +69,7 @@ static int onboard_hub_power_on(struct onboard_hub *hub) err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to enable supplies: %d\n", err); + dev_err(hub->dev, "failed to enable supplies: %pe\n", ERR_PTR(err)); return err; } @@ -88,7 +89,7 @@ static int onboard_hub_power_off(struct onboard_hub *hub) err = regulator_bulk_disable(hub->pdata->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to disable supplies: %d\n", err); + dev_err(hub->dev, "failed to disable supplies: %pe\n", ERR_PTR(err)); return err; } @@ -235,7 +236,7 @@ static void onboard_hub_attach_usb_driver(struct work_struct *work) err = driver_attach(&onboard_hub_usbdev_driver.drvwrap.driver); if (err) - pr_err("Failed to attach USB driver: %d\n", err); + pr_err("Failed to attach USB driver: %pe\n", ERR_PTR(err)); } static int onboard_hub_probe(struct platform_device *pdev) @@ -262,7 +263,7 @@ static int onboard_hub_probe(struct platform_device *pdev) err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies); if (err) { - dev_err(dev, "Failed to get regulator supplies: %d\n", err); + dev_err(dev, "Failed to get regulator supplies: %pe\n", ERR_PTR(err)); return err; }