| Message ID | 20240114034054.28562-2-rahimi.mhmmd@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7ebe52f3e7bcb57eb29b47fcbd23b4a5fed6b302 |
| Headers | show |
| Series | thunderbolt: Fix xdomain rx_lanes_show and tx_lanes_show | expand |
On Sun, Jan 14, 2024 at 11:40:54AM +0800, Mohammad Rahimi wrote: > If the Inter-Domain link is operating in asymmetric TB_LINK_WIDTH_ASYM_TX > mode, the rx_lanes_show should return 1 since there is only one receiver > and tx_lanes_show should return 3 since there are 3 transmitters. > > Signed-off-by: Mohammad Rahimi <rahimi.mhmmd@gmail.com> Applied to thunderbolt.git/next, thanks! This is kind of cosmetic thing because it is not allowed to have asymmetric link over host-to-host connection according to the spec but maybe somewhere in the future...
diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c index 9803f0bbf20d..3e5c8aa06bed 100644 --- a/drivers/thunderbolt/xdomain.c +++ b/drivers/thunderbolt/xdomain.c @@ -1786,13 +1786,13 @@ static ssize_t rx_lanes_show(struct device *dev, struct device_attribute *attr, switch (xd->link_width) { case TB_LINK_WIDTH_SINGLE: - case TB_LINK_WIDTH_ASYM_RX: + case TB_LINK_WIDTH_ASYM_TX: width = 1; break; case TB_LINK_WIDTH_DUAL: width = 2; break; - case TB_LINK_WIDTH_ASYM_TX: + case TB_LINK_WIDTH_ASYM_RX: width = 3; break; default: @@ -1812,13 +1812,13 @@ static ssize_t tx_lanes_show(struct device *dev, struct device_attribute *attr, switch (xd->link_width) { case TB_LINK_WIDTH_SINGLE: - case TB_LINK_WIDTH_ASYM_TX: + case TB_LINK_WIDTH_ASYM_RX: width = 1; break; case TB_LINK_WIDTH_DUAL: width = 2; break; - case TB_LINK_WIDTH_ASYM_RX: + case TB_LINK_WIDTH_ASYM_TX: width = 3; break; default:
If the Inter-Domain link is operating in asymmetric TB_LINK_WIDTH_ASYM_TX mode, the rx_lanes_show should return 1 since there is only one receiver and tx_lanes_show should return 3 since there are 3 transmitters. Signed-off-by: Mohammad Rahimi <rahimi.mhmmd@gmail.com> --- drivers/thunderbolt/xdomain.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)