diff mbox series

[next] USB: serial: keyspan: Remove redundant assignment to pointer data

Message ID 20240207104128.2441210-1-colin.i.king@gmail.com (mailing list archive)
State Accepted
Commit 9532ac14d8b2216236c02d9903b373dec46410e2
Headers show
Series [next] USB: serial: keyspan: Remove redundant assignment to pointer data | expand

Commit Message

Colin Ian King Feb. 7, 2024, 10:41 a.m. UTC
The pointer data is being assigned a value that is not being
read afterwards, it is being re-assigned later inside a do-while
loop. The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/usb/serial/keyspan.c:924:2: warning: Value stored to 'data'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/usb/serial/keyspan.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Johan Hovold March 4, 2024, 1:55 p.m. UTC | #1
On Wed, Feb 07, 2024 at 10:41:28AM +0000, Colin Ian King wrote:
> The pointer data is being assigned a value that is not being
> read afterwards, it is being re-assigned later inside a do-while
> loop. The assignment is redundant and can be removed.
> 
> Cleans up clang scan warning:
> drivers/usb/serial/keyspan.c:924:2: warning: Value stored to 'data'
> is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied, thanks.

Johan
diff mbox series

Patch

diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index 93b17e0e05a3..0a783985197c 100644
--- a/drivers/usb/serial/keyspan.c
+++ b/drivers/usb/serial/keyspan.c
@@ -921,7 +921,6 @@  static void usa28_indat_callback(struct urb *urb)
 
 	port =  urb->context;
 	p_priv = usb_get_serial_port_data(port);
-	data = urb->transfer_buffer;
 
 	if (urb != p_priv->in_urbs[p_priv->in_flip])
 		return;