| Message ID | 20240227090228.22156-2-macpaul.lin@mediatek.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 966bf794e04358c68c4247302d02b587f41c5d09 |
| Headers | show |
| Series | [1/2] dt-bindings: usb: Add binding for TI USB8020B hub controller | expand |
Il 27/02/24 10:02, Macpaul Lin ha scritto: > The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for > this hub in the driver in order to bring up reset, and supply > dependencies. > > Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Tue, Feb 27, 2024 at 05:02:28PM +0800, Macpaul Lin wrote: > The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for > this hub in the driver in order to bring up reset, and supply > dependencies. > > Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> Generally this looks good to me, but it should probably wait for "usb: misc: onboard_dev: use device supply names" [1] to land and use a device specific supply name instead of 'vdd'. [1] https://lore.kernel.org/linux-usb/20240220-onboard_xvf3500-v4-6-dc1617cc5dd4@wolfvision.net/
diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index 1e169c97f45e..e19c11a64923 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -457,6 +457,8 @@ static const struct usb_device_id onboard_hub_id_table[] = { { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1 */ { USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2 */ { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1 */ + { USB_DEVICE(VENDOR_ID_TI, 0x8025) }, /* TI USB8020B 3.0 */ + { USB_DEVICE(VENDOR_ID_TI, 0x8027) }, /* TI USB8020B 2.0 */ { USB_DEVICE(VENDOR_ID_TI, 0x8140) }, /* TI USB8041 3.0 */ { USB_DEVICE(VENDOR_ID_TI, 0x8142) }, /* TI USB8041 2.0 */ { USB_DEVICE(VENDOR_ID_VIA, 0x0817) }, /* VIA VL817 3.1 */ diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index 373192afd022..874473e60132 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -31,6 +31,11 @@ static const struct onboard_hub_pdata realtek_rts5411_data = { .num_supplies = 1, }; +static const struct onboard_hub_pdata ti_tusb8020b_data = { + .reset_us = 3000, + .num_supplies = 1, +}; + static const struct onboard_hub_pdata ti_tusb8041_data = { .reset_us = 3000, .num_supplies = 1, @@ -70,6 +75,8 @@ static const struct of_device_id onboard_hub_match[] = { { .compatible = "usb424,2744", .data = µchip_usb5744_data, }, { .compatible = "usb424,5733", .data = µchip_usb5734_data, }, { .compatible = "usb424,5744", .data = µchip_usb5744_data, }, + { .compatible = "usb451,8025", .data = &ti_tusb8020b_data, }, + { .compatible = "usb451,8027", .data = &ti_tusb8020b_data, }, { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, { .compatible = "usb4b4,6504", .data = &cypress_hx3_data, },
The TI TUSB8020B is a 2-port USB 3.0 hub. Add support for this hub in the driver in order to bring up reset, and supply dependencies. Power-up: Issue a GPIO reset (GRSTz) 3ms after VDD and VDD33 stabilize. Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- drivers/usb/misc/onboard_usb_hub.c | 2 ++ drivers/usb/misc/onboard_usb_hub.h | 7 +++++++ 2 files changed, 9 insertions(+)