diff mbox series

[next,V2] usb: gadget: net2272: Use irqflags in the call to net2272_probe_fin

Message ID 20240307181734.2034407-1-colin.i.king@gmail.com (mailing list archive)
State Accepted
Commit 600556809f04eb3bbccd05218215dcd7b285a9a9
Headers show
Series [next,V2] usb: gadget: net2272: Use irqflags in the call to net2272_probe_fin | expand

Commit Message

Colin Ian King March 7, 2024, 6:17 p.m. UTC
Currently the variable irqflags is being set but is not being used,
it appears it should be used in the call to net2272_probe_fin
rather than IRQF_TRIGGER_LOW being used. Kudos to Uwe Kleine-König
for suggesting the fix.

Cleans up clang scan build warning:
drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags'
set but not used [-Wunused-but-set-variable]

Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller")

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---

V2: don't remove irqflags but instead use it in the call to net2272_probe_fin

---
 drivers/usb/gadget/udc/net2272.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alan Stern March 7, 2024, 6:31 p.m. UTC | #1
On Thu, Mar 07, 2024 at 06:17:34PM +0000, Colin Ian King wrote:
> Currently the variable irqflags is being set but is not being used,
> it appears it should be used in the call to net2272_probe_fin
> rather than IRQF_TRIGGER_LOW being used. Kudos to Uwe Kleine-König
> for suggesting the fix.
> 
> Cleans up clang scan build warning:
> drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags'
> set but not used [-Wunused-but-set-variable]
> 
> Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller")
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Acked-by: Alan Stern <stern@rowland.harvard.edu>

> ---
> 
> V2: don't remove irqflags but instead use it in the call to net2272_probe_fin
> 
> ---
>  drivers/usb/gadget/udc/net2272.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
> index 12e76bb62c20..19bbc38f3d35 100644
> --- a/drivers/usb/gadget/udc/net2272.c
> +++ b/drivers/usb/gadget/udc/net2272.c
> @@ -2650,7 +2650,7 @@ net2272_plat_probe(struct platform_device *pdev)
>  		goto err_req;
>  	}
>  
> -	ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW);
> +	ret = net2272_probe_fin(dev, irqflags);
>  	if (ret)
>  		goto err_io;
>  
> -- 
> 2.39.2
> 
>
Uwe Kleine-König March 10, 2024, 11:20 a.m. UTC | #2
Hello,

On Thu, Mar 07, 2024 at 06:17:34PM +0000, Colin Ian King wrote:
> Currently the variable irqflags is being set but is not being used,
> it appears it should be used in the call to net2272_probe_fin
> rather than IRQF_TRIGGER_LOW being used. Kudos to Uwe Kleine-König
> for suggesting the fix.
> 
> Cleans up clang scan build warning:
> drivers/usb/gadget/udc/net2272.c:2610:15: warning: variable 'irqflags'
> set but not used [-Wunused-but-set-variable]
> 
> Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller")
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe
diff mbox series

Patch

diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
index 12e76bb62c20..19bbc38f3d35 100644
--- a/drivers/usb/gadget/udc/net2272.c
+++ b/drivers/usb/gadget/udc/net2272.c
@@ -2650,7 +2650,7 @@  net2272_plat_probe(struct platform_device *pdev)
 		goto err_req;
 	}
 
-	ret = net2272_probe_fin(dev, IRQF_TRIGGER_LOW);
+	ret = net2272_probe_fin(dev, irqflags);
 	if (ret)
 		goto err_io;