From patchwork Mon Apr 8 01:06:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13620357 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0455110E9 for ; Mon, 8 Apr 2024 01:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712538404; cv=none; b=ABl7NiAAAPCLJNYy3r/bYIczOg9iY7BEW25liPXh3GwYzzusYVXobUBLpR6mPERSQ9P1K222azhDT4iX0pnVwNJtH/pjJhF21h5ZkJiHEJxPQzrhr0UcTvhYlPeQtqtjdiB2evBs0QJAKNXJAgAeeLNsv6K31rdTWGojFWicFzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712538404; c=relaxed/simple; bh=d+ruzdmvGa/okGAGeYbBxEzaBs0mn1exB2go+KqLJPk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=lqh+OGSC72xtn+Kqnd+yWG6E6LgkaVEg7BgjapuktG2kMCsb2l8fBfajqUyOEF/RQVVs5qMFH/Z8TeC/Nm6R/rzhe2J3zVLbqkJ/eqBnKiHmgmE+CE8cwKJr92PUPz/xooTSO5w6I7lGsbdRS9lm1EWYYzkSvRJM8FXtgEIB9bc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=pjcxxf8l; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pjcxxf8l" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-56e448d6f9cso412436a12.0 for ; Sun, 07 Apr 2024 18:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712538401; x=1713143201; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=UVWIf+cNR8uAkF1rG7ZsWkZNC2MxcJK/X8n15oF2cWA=; b=pjcxxf8lkkCVyNC0NvJpX/IwNCpXYitiC90mBlmPLmkY9UQq4xl+KJK6M+qCHUessC 0b20KvWTZrqj8O70yA0/mnquvSSS8VxubmsUG+Nd71EOAMvXNXad6SZEU9ZX0r4/dQgQ W+llfJbF5nBIMA1624MDmGkJGG4jRctSAQxpetmQ0FrcL7OTEuDMg3mKHVtk81A+67OI BlVJReV0nK3kGZui/MbXJ7PqF4Bp27JtV32TEsVpGe9HhUr8Pvvl5bpKyx0u1G4LX05x T/G+DyLGGgHKCGJ+LEFeS2xRxyPKS4SoiiE6Eki8YiAtdMOBguF9fd6kwFewSPYNlW7/ Yf7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712538401; x=1713143201; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UVWIf+cNR8uAkF1rG7ZsWkZNC2MxcJK/X8n15oF2cWA=; b=XMF3DV5E69gOo0uDSkA9yLFEpnmBEgPI2yAQfuvFojM+GaZMCTfkQdOKe53Vloz7G8 +CKpCXoJkDyX0WzlCIwuBPw0r5ll7QnGpeoHnf8ASsGyAuj+aVV6ZBkmrcIOqdWibfw/ WghjJcyfvCmrpIXhRTT+woVIV3tn2YjZEbo3TvrhY+BAx/VkzrjumbnF77AHKwW2oiFd JfmKVWyyEVbPLcAOWcJs96SBArnSht1uTMM1V9sG7rRdLRG1vTfZi5TS6h8+Lmi7TJu7 doyK805vYhYFCEIFsMfuhoBf4iRq40tQN+nnAuE2t3WHu3FTm5ckhyq6PZ6lo4R1CL6x U8bw== X-Forwarded-Encrypted: i=1; AJvYcCVRghVwXDdNZXBg18cKxrXOxgImYzkrn2YV5e6m0Hmh+B6hRTpsaWeI6vFtRQoxLKyMwcpiN9L1awzBT+HKrc6nFV98IXsmK+Ac X-Gm-Message-State: AOJu0Yyr1PCF9mBQGnNkrLIjp9IaVlUGCJz4Jc3NcRXht26FsJPxspoE zdQzAvXppd3Ts3XhhA8TBTJVw79eZl2yz1RmTb2w1h/ZqTwwdzKraNUiHyqCIrs= X-Google-Smtp-Source: AGHT+IGbS984iRveFDFXvDEXPDi5nYh6QK1hCEBKraYaVmtp7WfgwASl+Y7Yy5kjRjKkUiiNzuWyCw== X-Received: by 2002:a50:a69a:0:b0:56e:309f:4cb3 with SMTP id e26-20020a50a69a000000b0056e309f4cb3mr5056356edc.16.1712538401181; Sun, 07 Apr 2024 18:06:41 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id b14-20020aa7c90e000000b0056e46beba6dsm2069990edt.16.2024.04.07.18.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 18:06:40 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 08 Apr 2024 04:06:40 +0300 Subject: [PATCH v2] usb: typec: qcom-pmic-typec: split HPD bridge alloc and registration Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240408-qc-pmic-typec-hpd-split-v2-1-1704f5321b73@linaro.org> X-B4-Tracking: v=1; b=H4sIAB9DE2YC/4WNQQ6CMBBFr0Jm7Zh2Wom68h6GRWkLTIK0toRIC He3cgGX7yX//Q2yT+wz3KsNkl84c5gK0KkCO5ip98iuMJAgLbS44NtifLHFeY3e4hAd5jjyjER XoUnIm6AWyjom3/HnKD+bwgPnOaT1OFrkz/5vLhIlqlo5Y7pWWVU/Rp5MCueQemj2ff8CmM0dD b8AAAA= To: Bryan O'Donoghue , Heikki Krogerus , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Caleb Connolly X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2202; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=d+ruzdmvGa/okGAGeYbBxEzaBs0mn1exB2go+KqLJPk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmE0MggQfqBW60Ab7/gmZuI/fIvOljKpi5FvEEv np6fKrtdTmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZhNDIAAKCRCLPIo+Aiko 1WlHB/4o8o82DHnzpyyKOvhmrDsG1qJVmkgeTP8m04DZzlWHpuQNOSerlSGwpQ9jjpB4iiC22AS sdT+E8no1yleTOLWqCIg0q4BtZI28dwvY739j9H2EMunRljXjhKFCB9PCcbhmw2EfU2XXVP0qS8 y6aXXfDoPlt5Ctae6baejV2GR7QNNLD7PgZFjZPkEpO0ynQx6kvarXaHOVtYgCKWgn+zW681nMM h7ac2+V3p72R0hwfTggIU3ui9ivhyVRHaCtQDOLHp8iD7o4vJ682yWNtGLHUxat9ixoSr/8KXBk OBn/oQb3gR8hlvTggf2ck3vbBsxDQK0njpocvAi5fDm43Xcc X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A If a probe function returns -EPROBE_DEFER after creating another device there is a change of ending up in a probe deferral loop, (see commit fbc35b45f9f6 ("Add documentation on meaning of -EPROBE_DEFER"). In order to prevent such probe-defer loops caused by qcom-pmic-typec driver, use the API added by Johan Hovold and move HPD bridge registration to the end of the probe function. Reported-by: Caleb Connolly Acked-by: Bryan O'Donoghue Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Fix commit message (Bryan) - Link to v1: https://lore.kernel.org/r/20240405-qc-pmic-typec-hpd-split-v1-1-363daafb3c36@linaro.org --- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- base-commit: a6bd6c9333397f5a0e2667d4d82fef8c970108f2 change-id: 20240405-qc-pmic-typec-hpd-split-22804201902b Best regards, diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c index e48412cdcb0f..96b41efae318 100644 --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c @@ -41,7 +41,7 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) struct device_node *np = dev->of_node; const struct pmic_typec_resources *res; struct regmap *regmap; - struct device *bridge_dev; + struct auxiliary_device *bridge_dev; u32 base; int ret; @@ -92,7 +92,7 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) if (!tcpm->tcpc.fwnode) return -EINVAL; - bridge_dev = drm_dp_hpd_bridge_register(tcpm->dev, to_of_node(tcpm->tcpc.fwnode)); + bridge_dev = devm_drm_dp_hpd_bridge_alloc(tcpm->dev, to_of_node(tcpm->tcpc.fwnode)); if (IS_ERR(bridge_dev)) return PTR_ERR(bridge_dev); @@ -110,6 +110,10 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) if (ret) goto fwnode_remove; + ret = devm_drm_dp_hpd_bridge_add(tcpm->dev, bridge_dev); + if (ret) + goto fwnode_remove; + return 0; fwnode_remove: