diff mbox series

[2/2] xhci: Apply broken streams quirk to Etron EJ188 xHCI host

Message ID 20240522023918.7613-1-ki.chiang65@gmail.com (mailing list archive)
State Superseded
Headers show
Series [1/2] xhci: Apply reset resume quirk to Etron EJ188 xHCI host | expand

Commit Message

Kuangyi Chiang May 22, 2024, 2:39 a.m. UTC
As described in commit 8f873c1ff4ca ("xhci: Blacklist using streams on the
Etron EJ168 controller"), EJ188 have the same issue as EJ168, where Streams
do not work reliable on EJ188. So apply XHCI_BROKEN_STREAMS quirk to EJ188
as well.

Signed-off-by: Kuangyi Chiang <ki.chiang65@gmail.com>
---
 drivers/usb/host/xhci-pci.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg Kroah-Hartman May 22, 2024, 4:35 a.m. UTC | #1
On Wed, May 22, 2024 at 10:39:17AM +0800, Kuangyi Chiang wrote:
> As described in commit 8f873c1ff4ca ("xhci: Blacklist using streams on the
> Etron EJ168 controller"), EJ188 have the same issue as EJ168, where Streams
> do not work reliable on EJ188. So apply XHCI_BROKEN_STREAMS quirk to EJ188
> as well.
> 
> Signed-off-by: Kuangyi Chiang <ki.chiang65@gmail.com>
> ---
>  drivers/usb/host/xhci-pci.c | 1 +
>  1 file changed, 1 insertion(+)

Should this go to stable kernels, if so, how far back?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index a0beb41..5591e6d 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -242,6 +242,7 @@  static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 	if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
 			pdev->device == PCI_DEVICE_ID_EJ188) {
 		xhci->quirks |= XHCI_RESET_ON_RESUME;
+		xhci->quirks |= XHCI_BROKEN_STREAMS;
 	}
 	if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
 	    pdev->device == 0x0014) {