From patchwork Thu Jun 6 09:03:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Carrasco X-Patchwork-Id: 13688096 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2137.outbound.protection.outlook.com [40.107.22.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9371A13E8BE; Thu, 6 Jun 2024 09:04:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664649; cv=fail; b=GCOGV3rxQC8u5a7iWwM14hSNZeATTI8SkmIpZ8AuT3I55FutLno3d2vlDNOfNvbyHNcWkI63Z4d4O8H7xclVNyu0ObGIpbXctmeusp8OLeFNdq3RpgGMo0U7r0160F1LxzSeWoO2nXqZ1fvl4Bb5FV9oLge3LnV51j+wpZF6hFU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664649; c=relaxed/simple; bh=aoQGd5ZliRw15hKnZTHa2KKfY2LRQ+HHwl3dLCuDzEo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=LL8SYLrR7owQ3EUZ1fXXyXKndyg02ZXVv8arYHKmO9KhqJRU8gSffzyzprJPcusjGHLMjsA4JUdSJKAVHAhhdWra6lgWO0PUuQ2X4B1TgkSmO6jRnTlMt2gO4h2Dc0cPJaTdN+QVEENsjjPooczPU6kkcbLIpbsIEqZunbUfdbM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wolfvision.net; spf=pass smtp.mailfrom=wolfvision.net; dkim=pass (1024-bit key) header.d=wolfvision.net header.i=@wolfvision.net header.b=xJnOkgDR; arc=fail smtp.client-ip=40.107.22.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wolfvision.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wolfvision.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=wolfvision.net header.i=@wolfvision.net header.b="xJnOkgDR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VIFHoQhVJIh1gUvFbUPv/BsQOSCAvful93BDyDkmWn6Hk5nhAA89oz8tv/wIf4/XbtYfYposVgwVOfa+SEdE0lzNr6eMODWwPI2b9z1mgbT9XmqpcnC47tTHJQNwVi7aCyYknJcvgDydHjlHJTMyL4lCcsG00cGhnT7jRsWXBJ8hlzotrlw+waSc+vTPD9272Hgd265ZGAlWlqfjeItdcnGjr5eqkE3T4HRYOidykzOBHhHuFOjtwLF4gnq71hO3VlJ1piMm8L3izRfAXaTgnF+li21fN+j7sQlCIM+Gf6djZm+lXQgNqK2rXkfmyMjx+KbKzR/PKuwTYHJjSQT+Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vAB2FzZBvrU7LxEpBzwymNV0PbYDBiDtlljYTeMWBt8=; b=iFSyJWdqGKFINUu9ECY5uA2u2AEn6BP9ujlizlHnIh/5Yj74ZETn5hevXxkKNcNQpczA76IAN19sQ4dTZ3xr12XakcMi8RUH7N4Q7Yzx4acOb+BsoWGkwe4wXAZZV2cWESXj4t5qbJP43J0iiX4vKig50D0FydBfqHlGrKeE10yRu8+75PxyVr2xINTPD/CGL/2E/Bl9Ut3R+SPVJ2klRit7Hwprk7fru23P/rd9tM7BMVZ40+YD7Xnum07PhYK7VoJypYWpdG/Kwg0UfVDZqJ9h6DZ+WEabtcJicc2xrMJwOFRNqR/D3MNr/gO9h8Ym45eP/+lDHxmjuNAkwBSd+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wolfvision.net; dmarc=pass action=none header.from=wolfvision.net; dkim=pass header.d=wolfvision.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfvision.net; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vAB2FzZBvrU7LxEpBzwymNV0PbYDBiDtlljYTeMWBt8=; b=xJnOkgDRqJYcZIW47xe0Ru0JeIfIwGx3QZubukBR7bt8lNxr0Crz7I1ZBik3EIxTPKKa/JzExabr9sQoN3ppjwx/y4QY3KW0IpqAvvICqXMc8P9RYoforqAeMOnmPc8zcm5ZM5nP8CG12YWNujiCqQ2gRW4lhE2d4aSzxuSjZzc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wolfvision.net; Received: from VE1PR08MB4974.eurprd08.prod.outlook.com (2603:10a6:803:111::15) by DB9PR08MB9513.eurprd08.prod.outlook.com (2603:10a6:10:459::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31; Thu, 6 Jun 2024 09:04:04 +0000 Received: from VE1PR08MB4974.eurprd08.prod.outlook.com ([fe80::a08:11be:8709:f5e1]) by VE1PR08MB4974.eurprd08.prod.outlook.com ([fe80::a08:11be:8709:f5e1%4]) with mapi id 15.20.7633.033; Thu, 6 Jun 2024 09:04:04 +0000 From: Javier Carrasco Date: Thu, 06 Jun 2024 11:03:56 +0200 Subject: [PATCH 2/3] usb: typec: tipd: add error log to provide firmware name and size Message-Id: <20240606-tps6598x_fw_update_log-v1-2-2b5b8369a0ba@wolfvision.net> References: <20240606-tps6598x_fw_update_log-v1-0-2b5b8369a0ba@wolfvision.net> In-Reply-To: <20240606-tps6598x_fw_update_log-v1-0-2b5b8369a0ba@wolfvision.net> To: Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1717664643; l=918; i=javier.carrasco@wolfvision.net; s=20240320; h=from:subject:message-id; bh=aoQGd5ZliRw15hKnZTHa2KKfY2LRQ+HHwl3dLCuDzEo=; b=KqpqGvn1uyKtq2if0MePRVBfvfyMu9hlH2Q5e2y7WBhrV84kmnAVYFPdC8AnYdRjrBjDckOiC 3cSuon7ILc7CycDQN5XEQ0tBIiX15GwD8SCCMcoAnnIrFaeSSkAw8nn X-Developer-Key: i=javier.carrasco@wolfvision.net; a=ed25519; pk=Vxk2/0sGIxM8rsKnceszFuSuHVfQwa1Yo8+is7BX2nY= X-ClientProxiedBy: VI1PR07CA0310.eurprd07.prod.outlook.com (2603:10a6:800:130::38) To VE1PR08MB4974.eurprd08.prod.outlook.com (2603:10a6:803:111::15) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR08MB4974:EE_|DB9PR08MB9513:EE_ X-MS-Office365-Filtering-Correlation-Id: 7501ae53-f733-4cd1-069b-08dc86079d2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|366007|1800799015|52116005|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?RfRHIDLAkzG3Ctcv6RejhDSd8xrusLR?= =?utf-8?q?98pYqnusd9g6xPDabVGe9SElPB4gS4NTOCkDllhnE5Wu72+qlLtHDGqTe4LZGgOP5?= =?utf-8?q?Hq2iSTXiSeUPVeVoDTuLemqGTDtAgbOjF09kCgKsAjMUSZSMzCe+TZHH4pMZ2s+CT?= =?utf-8?q?WpQijqdqnlY437KdyV0w4eHahoUhC299jVIOXugQZqpBFIbk0C2UyHcQVCwrOEQXK?= =?utf-8?q?jeoX0FX4Kq1qe47KnCDjljO/h7semKpvkTg4uV7c7qeHPGQBlqWkbHQ10o95FKOsx?= =?utf-8?q?fzQXYW1R7a5TMJNPc2WjKYgnWYhoeuMS+MavlXnBETQqO6RsQxJahcxkhJjcLDWW0?= =?utf-8?q?HJa6ZgCu1cqSbe4P8VSkRjvdzutujekbOfE5skyVd/7jDI+aEvSz6vJ0D+uzagz1G?= =?utf-8?q?BciplA+c5nNhWCRpRfZ350pUlY5c5EGLjNwXcgymUPCyCgEF746Tst6quxmKF3l7K?= =?utf-8?q?laCTbD308QU1dZpZAB5hAwPWQrm6Ee26/hHTQI/dxGEnIaS657xdUGqmOGrcZYOLp?= =?utf-8?q?u/29w+ltuALpG22u6YZndibg+2H1InZiLSbwCjiWQQR2mo/XpU6z+vITYX3F5osSj?= =?utf-8?q?RdArUoEsoWyXVHhK6ba60c+BZPFcC4XSJlXTVfK+C8qAzdbgYdtC1SlzMfpL/6VYp?= =?utf-8?q?c6SVyhLRAsORJm9CHWCOzQ4P+4xAxt9U9mlnqKkXzpywbe7OplzDHVCmjU4giOwVP?= =?utf-8?q?T8OCLLvtMHE3kVQmFTfILgId1/9AKwQquu/9U5AKGyWadGhXCvX3eycDmfz9XTPDS?= =?utf-8?q?Y0opFGj05sKBsyYXWjL7BqHoDPkyuOAzBSO/jPIXjd4WBlHAdchLrMX9fX1wNrrAF?= =?utf-8?q?qLN072qxrJxRI3cicNFgT+MLKCVhA1UhaW51M8HM+n6jjVJh+vgmNSvMOd368TUqJ?= =?utf-8?q?m5P2soA95jwoASrYqIwsQO88TLoPA8yuLYur2ZlBL8UKpY9QDfY8p6Uiy4yq+wofY?= =?utf-8?q?IenusUqDAtdX2/RnaZvj0IU+T1crQujnpj/lSSuCstMbwFjP4asZmhhlTAs7cqAkA?= =?utf-8?q?O0RCRjVOOEwOo1/Lggg0g19gTvZ7SOKOwToehhzm/RSlaDoLbKYqEqZyyFoFodgA6?= =?utf-8?q?6mdmtmL36EixJJvOzHDCWbrFdTUBtj5ZLCRuSHomoiIqNWl56AnzXug1lGdDBNiL3?= =?utf-8?q?mM2FA1Xnrtqzb+6z/tsQU1jGtfitvi3BaEg/cZ2SZPifjp0ziSPKZuB3lkMuBu8CA?= =?utf-8?q?3fTAZorwFWASu5SwvWJuM1R8QRLv7ZxA+ZCK9TG8VTTtmHgWbed/Nt1ijbj8+359h?= =?utf-8?q?FnTTNP36YWTK8QbBUHeNksnzsoXiQBtSE1Tm3Cig6z+Aaj/gbj38zrs0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB4974.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(52116005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?O8eVECP/fKUXm6UckG/7wMXJYxhP?= =?utf-8?q?OxjpRfNuLiX+7MzAUAcZFnTvGY/7iOYvI+mO0t5X3WNz6jj32H48jtSx1P36uwRpe?= =?utf-8?q?3QxXln/bw9f5fbc6KZkzHupOck35MEPdZXp2YM5Y7Vw1SsSkKoeb9GU0oKpx9CVPe?= =?utf-8?q?Zi1/VtnLLmaXz0oI4FwxD5aYPmhXIDYebxtdDsgRnpsBRruEPDnaxQISgnTerpqsQ?= =?utf-8?q?3+IptZJTTD0DPxGicBnthvTaC8jkY6wXiX6Xbf8oqXXRHWc96oifZC1Ct5yPRYURz?= =?utf-8?q?e4Ymha81H6jiLUSixL0xhvkaGyuIJ+86KrqlQjTUJ5LeERcuZchbrNuwMSAtioDNs?= =?utf-8?q?qdthMGH+D3UAM1glpbbC5RjcbuG8z/VVza+37704LyZPom6FRDULZPegXsp+QN1uI?= =?utf-8?q?Nk3b3yHGhnrY73n2ebnrqUykmHZYlfi/LSr1z3S2ll4H6RfQAC0SwUVr/yz6DICl7?= =?utf-8?q?XYT+NzwYSbDjMIEmTin7Q/XA+xqZGk5fc9Rfv6WUZ44NmFOqv5xlWVtvQ/3KQLVVR?= =?utf-8?q?FY2uwaxBGvLIZqgpdDidIHa8rk1iEExyZXld23hmsP6BD3niPJLLuoKWvQSfU0AWf?= =?utf-8?q?jS2P8HfKKv7AJr5hOjJjyN6/qv0E3tNjvNhr6UmBHSx2Nii71caSGCAXXdeD0TmCJ?= =?utf-8?q?aMNI2xIzY8b2qS8BMuyP8d/OeZXpBnjqSomNmImLfDn+Eb2gX0phZrotielVULRXN?= =?utf-8?q?/ovaSZGBFERtJ0DnIgrazRBpO8HCCowthexv+PI5zKvCjuAzmnfNWmAJB75Mdmk1b?= =?utf-8?q?KfuAGJs6QfappToTp5ZuCW1PK7a7e5Ri//zDWczjHauG3VXYuTg6byExOa6Ix8kMV?= =?utf-8?q?bdGfNMXTfhrAwKb/5CLLWHA/SjO0vP3BKzTuXF4/C5QtSGRMqmC2fX5uPthQcqo2Y?= =?utf-8?q?TR7sxohALn6OqUI+r26WWtZu5yrCcXCLrF5AO1lz2rgwBcu+Cm/eciVuDfSvt9ihB?= =?utf-8?q?Tmi142sk8GO/r4kB+kmifbH/tuBCE4ZbqeCR3jtHEGpiahy1hM0NNuh5M4mXSPLBg?= =?utf-8?q?wfgvWJPcyituEGPAhQsrV1d7yAKSbLg9K1SN9nzGlDNM4i+ovLvvXAvdZijujgR6p?= =?utf-8?q?+RtY3Fc1GBma4I/1A1fAR86RmmGbBbw+BEKjqhNxYdKuqm9TcPS726VFcFsipMkd/?= =?utf-8?q?3xO7PdZoo7N/+bIa5aDAPuXCNXT9mFTh7AxRmThcvojrw2SXKcZeZCbu8GmJsMchQ?= =?utf-8?q?+HFNEIbtEHCFRKGwsXc3LNko+Rd5V1CPuzOjAMsVzN93mMGV5uOaajtnkPjwvPvr7?= =?utf-8?q?nmEuzSv5T4C5xNAgCFiqjRBOqctylOHZUFNcdzvgPXsZmwZpVbMcKufAewdgQwAgQ?= =?utf-8?q?rY/roRSjROOTRqJUXnLMz50UxmdhPP7nwhNRh25i55XsIEKMnzF9mR4ka7drZLiK7?= =?utf-8?q?0XWjlhLHnRwbdQRPmH0b3iSuhnZvEFCL7fbdRchSoMuHTkRYYl5yWXY4aGMJhuM2c?= =?utf-8?q?IHX/fv4Bp+xTDs7Nbl3wRcaXKhpYPWdgKYrI7lOLURzi7G/uAWujK/w1DtB3PUxO1?= =?utf-8?q?wMcZwXDhFncSXJMtRSaXf6cFECdapjHl1DAoF3OIBVhVGmjtPU3Wl4o=3D?= X-OriginatorOrg: wolfvision.net X-MS-Exchange-CrossTenant-Network-Message-Id: 7501ae53-f733-4cd1-069b-08dc86079d2d X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 09:04:04.0570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QnupOk8Y7g0SqtjlwufvtXey6sqeZSIKO+sM6wVBdMBd3tQV8PWvQFgta1vVS8nAIy3XrksKnwkItSqK0nYDoIBYj0vHu8NI/epQ/ZWnTz8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9513 The current error logs do not show the firmware name and size for the tps6598x. On the other hand, this information is provided for the tps25750. Both implementations have access to that information, and the existing message for the tps25750 can be used for the tps6598x without extra modifications. Signed-off-by: Javier Carrasco Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tipd/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 851b0d02727a..58f6eeffd070 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -1195,6 +1195,10 @@ static int tps6598x_apply_patch(struct tps6598x *tps) release_fw: release_firmware(fw); + if (ret) { + dev_err(tps->dev, "Failed to write patch %s of %zu bytes\n", + firmware_name, fw->size); + } return ret; };