| Message ID | 20240619-garmin_gps_counted_by-v2-1-f82f10ebbf28@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 55a15b3a713a3f24360cf9d8dcfd2a3e337321d6 |
| Headers | show |
| Series | USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by | expand |
On 19/06/24 21:42, Javier Carrasco wrote: > Use the __counted_by compiler attribute for the data[] flexible array > member to improve the results of array bound sanitizers. > > Reviewed-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Thanks -- Gustavo > --- > drivers/usb/serial/garmin_gps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c > index 670e942fdaaa..57df6ad183ff 100644 > --- a/drivers/usb/serial/garmin_gps.c > +++ b/drivers/usb/serial/garmin_gps.c > @@ -104,7 +104,7 @@ struct garmin_packet { > int seq; > /* the real size of the data array, always > 0 */ > int size; > - __u8 data[]; > + __u8 data[] __counted_by(size); > }; > > /* structure used to keep the current state of the driver */ >
On Wed, Jun 19, 2024 at 09:42:44PM +0200, Javier Carrasco wrote: > Use the __counted_by compiler attribute for the data[] flexible array > member to improve the results of array bound sanitizers. > > Reviewed-by: Nathan Chancellor <nathan@kernel.org> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Reviewed-by: Kees Cook <kees@kernel.org>
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index 670e942fdaaa..57df6ad183ff 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c @@ -104,7 +104,7 @@ struct garmin_packet { int seq; /* the real size of the data array, always > 0 */ int size; - __u8 data[]; + __u8 data[] __counted_by(size); }; /* structure used to keep the current state of the driver */