diff mbox series

[v3] usb: gadget: aspeed_udc: validate endpoint index for ast udc

Message ID 20240625020326.2564860-1-make24@iscas.ac.cn (mailing list archive)
State Superseded
Headers show
Series [v3] usb: gadget: aspeed_udc: validate endpoint index for ast udc | expand

Commit Message

Ma Ke June 25, 2024, 2:03 a.m. UTC 
From: Ma Ke <make_ruc2021@163.com>

We should verify the bound of the array to assure that host
may not manipulate the index to point past endpoint array.

Found by static analysis.

Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
Changes in v3:
- added the changelog as suggested.
Changes in v2:
- use correct macro-defined constants as suggested;
- explain the method for finding and testing vulnearabilities.
---
 drivers/usb/gadget/udc/aspeed_udc.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 3916c8e2ba01..d972ef4644bc 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1009,6 +1009,8 @@  static void ast_udc_getstatus(struct ast_udc_dev *udc)
 		break;
 	case USB_RECIP_ENDPOINT:
 		epnum = crq.wIndex & USB_ENDPOINT_NUMBER_MASK;
+		if (epnum >= AST_UDC_NUM_ENDPOINTS)
+			goto stall;
 		status = udc->ep[epnum].stopped;
 		break;
 	default: