| Message ID | 20240705081709.105496-1-slark_xiao@163.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | USB: serial: option: add support for Foxconn T99W651 | expand |
On Fri, Jul 05, 2024 at 04:17:09PM +0800, Slark Xiao wrote: > T99W651 is a RNDIS based modem device. There are 3 serial ports > need to be enumerated: Diag, NMEA and AT. > Signed-off-by: Slark Xiao <slark_xiao@163.com> Applied, thanks. Johan
At 2024-07-05 17:06:48, "Johan Hovold" <johan@kernel.org> wrote: >On Fri, Jul 05, 2024 at 04:17:09PM +0800, Slark Xiao wrote: >> T99W651 is a RNDIS based modem device. There are 3 serial ports >> need to be enumerated: Diag, NMEA and AT. > >> Signed-off-by: Slark Xiao <slark_xiao@163.com> > >Applied, thanks. > >Johan Hi Johan, I have a concern about the test result of "usb-devices" in Ubuntu 22.04. Do you know why it wouldn't show our devices any more?
On Fri, Jul 05, 2024 at 05:11:22PM +0800, Slark Xiao wrote: > I have a concern about the test result of "usb-devices" in Ubuntu > 22.04. Do you know why it wouldn't show our devices any more? No, sorry, no idea. Everything seems to work here with the latest usbutils-017. Is it just your devices that no longer show up or doesn't it work at all? Perhaps a change like this one could be involved: https://github.com/gregkh/usbutils/commit/3b79e9c866a17f0a5178b3b0bee63fab59a0003a I suggest you try an older version first and then either file a bug on github or to Ubuntu. Johan
At 2024-07-05 17:22:13, "Johan Hovold" <johan@kernel.org> wrote: >On Fri, Jul 05, 2024 at 05:11:22PM +0800, Slark Xiao wrote: > >> I have a concern about the test result of "usb-devices" in Ubuntu >> 22.04. Do you know why it wouldn't show our devices any more? > >No, sorry, no idea. Everything seems to work here with the latest >usbutils-017. > >Is it just your devices that no longer show up or doesn't it work at >all? > A lot of devices missed in Ubuntu 22.04, especially for modem devices. Nothing would be printed for modem devices. >Perhaps a change like this one could be involved: > > https://github.com/gregkh/usbutils/commit/3b79e9c866a17f0a5178b3b0bee63fab59a0003a > >I suggest you try an older version first and then either file a bug on >github or to Ubuntu. > >Johan I will check more details . Thanks for that!
On Fri, Jul 05, 2024 at 05:34:06PM +0800, Slark Xiao wrote: > > At 2024-07-05 17:22:13, "Johan Hovold" <johan@kernel.org> wrote: > >On Fri, Jul 05, 2024 at 05:11:22PM +0800, Slark Xiao wrote: > > > >> I have a concern about the test result of "usb-devices" in Ubuntu > >> 22.04. Do you know why it wouldn't show our devices any more? > > > >No, sorry, no idea. Everything seems to work here with the latest > >usbutils-017. > > > >Is it just your devices that no longer show up or doesn't it work at > >all? > > > A lot of devices missed in Ubuntu 22.04, especially for modem devices. > Nothing would be printed for modem devices. What specific version of usbutils are you using? If you pull from the github repo, can you try the version there? And if that has problems, a diff of both working and not-working would be great. thanks, greg k-h
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 178760bc7b92..4a43cec86db7 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -2294,6 +2294,8 @@ static const struct usb_device_id option_ids[] = { .driver_info = RSVD(3) }, { USB_DEVICE_INTERFACE_CLASS(0x0489, 0xe0f0, 0xff), /* Foxconn T99W373 MBIM */ .driver_info = RSVD(3) }, + { USB_DEVICE_INTERFACE_CLASS(0x0489, 0xe145, 0xff), /* Foxconn T99W651 RNDIS */ + .driver_info = RSVD(5) | RSVD(6) }, { USB_DEVICE(0x1508, 0x1001), /* Fibocom NL668 (IOT version) */ .driver_info = RSVD(4) | RSVD(5) | RSVD(6) }, { USB_DEVICE(0x1782, 0x4d10) }, /* Fibocom L610 (AT mode) */
T99W651 is a RNDIS based modem device. There are 3 serial ports need to be enumerated: Diag, NMEA and AT. Test evidence as below: T: Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 6 Spd=480 MxCh= 0 D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=0489 ProdID=e145 Rev=05.15 S: Manufacturer=QCOM S: Product=SDXPINN-IDP _SN:93B562B2 S: SerialNumber=82e6fe26 C: #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA I: If#=0x0 Alt= 0 #EPs= 1 Cls=ef(misc ) Sub=04 Prot=01 Driver=rndis_host I: If#=0x1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option I: If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option I: If#=0x4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option I: If#=0x5 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=70 Driver=(none) I: If#=0x6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none) 0&1: RNDIS, 2:AT, 3:NMEA, 4:DIAG, 5:QDSS, 6:ADB QDSS is not a serial port. Signed-off-by: Slark Xiao <slark_xiao@163.com> --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+)