| Message ID | 20240726113207.3393247-3-xu.yang_2@nxp.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d40ae4cdd9a400dea9dff3408b8c8983c45e943f |
| Headers | show |
| Series | [v2,1/6] usb: phy: mxs: enable regulator phy-3p0 to improve signal qualilty | expand |
> Subject: [PATCH v2 3/6] dt-bindings: phy: mxs-usb-phy: add nxp,sim > property > > i.MX7ULP need properly set System Integration Module(SIM) module > to make usb wakeup work well. This will add a "nxp,sim" property. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v2: > - add else branch suggested by Rob > --- > .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 > +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs- > usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs- > usbphy.yaml > index f4b1ca2fb562..ce665a2779b7 100644 > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > @@ -87,6 +87,12 @@ properties: > maximum: 119 > default: 100 > > + nxp,sim: "nxp,imx7ulp-sim" should be better. SIM is specific to i.MX7ULP as of now. Regards, Peng.
On 29/07/2024 03:03, Peng Fan wrote: >> Subject: [PATCH v2 3/6] dt-bindings: phy: mxs-usb-phy: add nxp,sim >> property >> >> i.MX7ULP need properly set System Integration Module(SIM) module >> to make usb wakeup work well. This will add a "nxp,sim" property. >> >> Signed-off-by: Xu Yang <xu.yang_2@nxp.com> >> >> --- >> Changes in v2: >> - add else branch suggested by Rob >> --- >> .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 >> +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs- >> usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs- >> usbphy.yaml >> index f4b1ca2fb562..ce665a2779b7 100644 >> --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml >> @@ -87,6 +87,12 @@ properties: >> maximum: 119 >> default: 100 >> >> + nxp,sim: > > "nxp,imx7ulp-sim" should be better. SIM is specific to i.MX7ULP as of now. Can you guarantee that? IOW, if you ever, ever come with another "sim" property for another SoC NXP agrees that it will be rejected? Properties should be defined once and naming such per-soc kind of contradicts it. Best regards, Krzysztof
> Subject: Re: [PATCH v2 3/6] dt-bindings: phy: mxs-usb-phy: add > nxp,sim property > > On 29/07/2024 03:03, Peng Fan wrote: > >> Subject: [PATCH v2 3/6] dt-bindings: phy: mxs-usb-phy: add nxp,sim > >> property > >> > >> i.MX7ULP need properly set System Integration Module(SIM) > module to > >> make usb wakeup work well. This will add a "nxp,sim" property. > >> > >> Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > >> > >> --- > >> Changes in v2: > >> - add else branch suggested by Rob > >> --- > >> .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 > >> +++++++++++++++++ > >> 1 file changed, 17 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs- > >> usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs- > >> usbphy.yaml > >> index f4b1ca2fb562..ce665a2779b7 100644 > >> --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > >> +++ b/Documentation/devicetree/bindings/phy/fsl,mxs- > usbphy.yaml > >> @@ -87,6 +87,12 @@ properties: > >> maximum: 119 > >> default: 100 > >> > >> + nxp,sim: > > > > "nxp,imx7ulp-sim" should be better. SIM is specific to i.MX7ULP as of > now. > > Can you guarantee that? IOW, if you ever, ever come with another > "sim" > property for another SoC NXP agrees that it will be rejected? I could not judge here. I was thinking, vendor,soc-ip is the preferred property. > > Properties should be defined once and naming such per-soc kind of > contradicts it. It is fine to keep nxp,sim as what the patch did. Regards, Peng. > > Best regards, > Krzysztof
On Fri, Jul 26, 2024 at 07:32:04PM +0800, Xu Yang wrote: > i.MX7ULP need properly set System Integration Module(SIM) module to make > usb wakeup work well. This will add a "nxp,sim" property. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v2: > - add else branch suggested by Rob > --- > .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > index f4b1ca2fb562..ce665a2779b7 100644 > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > @@ -87,6 +87,12 @@ properties: > maximum: 119 > default: 100 > > + nxp,sim: > + description: > + The system integration module (SIM) provides system control and chip > + configuration registers. > + $ref: /schemas/types.yaml#/definitions/phandle > + > required: > - compatible > - reg > @@ -110,6 +116,17 @@ allOf: > required: > - fsl,anatop > > + - if: > + properties: > + compatible: > + const: fsl,imx7ulp-usbphy > + then: > + required: > + - nxp,sim > + else: > + properties: > + nxp,sim: false > + > additionalProperties: false > > examples: A gentle ping. If it's fine, please add tag for this binding patch. The rest of the patches (expect dts) are already merged to mainline. Thanks, Xu Yang > -- > 2.34.1 >
On 26/07/2024 13:32, Xu Yang wrote: > i.MX7ULP need properly set System Integration Module(SIM) module to make > usb wakeup work well. This will add a "nxp,sim" property. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Greg, On Fri, Jul 26, 2024 at 07:32:04PM +0800, Xu Yang wrote: > i.MX7ULP need properly set System Integration Module(SIM) module to make > usb wakeup work well. This will add a "nxp,sim" property. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v2: > - add else branch suggested by Rob > --- > .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > index f4b1ca2fb562..ce665a2779b7 100644 > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > @@ -87,6 +87,12 @@ properties: > maximum: 119 > default: 100 > > + nxp,sim: > + description: > + The system integration module (SIM) provides system control and chip > + configuration registers. > + $ref: /schemas/types.yaml#/definitions/phandle > + > required: > - compatible > - reg > @@ -110,6 +116,17 @@ allOf: > required: > - fsl,anatop > > + - if: > + properties: > + compatible: > + const: fsl,imx7ulp-usbphy > + then: > + required: > + - nxp,sim > + else: > + properties: > + nxp,sim: false > + > additionalProperties: false > > examples: Could you please pick up patch #3? Rest of the patches are mainlined. Thanks, Xu Yang > -- > 2.34.1 >
On Thu, Aug 29, 2024 at 05:09:35PM +0800, Xu Yang wrote: > Hi Greg, > > On Fri, Jul 26, 2024 at 07:32:04PM +0800, Xu Yang wrote: > > i.MX7ULP need properly set System Integration Module(SIM) module to make > > usb wakeup work well. This will add a "nxp,sim" property. > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > --- > > Changes in v2: > > - add else branch suggested by Rob > > --- > > .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > index f4b1ca2fb562..ce665a2779b7 100644 > > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > @@ -87,6 +87,12 @@ properties: > > maximum: 119 > > default: 100 > > > > + nxp,sim: > > + description: > > + The system integration module (SIM) provides system control and chip > > + configuration registers. > > + $ref: /schemas/types.yaml#/definitions/phandle > > + > > required: > > - compatible > > - reg > > @@ -110,6 +116,17 @@ allOf: > > required: > > - fsl,anatop > > > > + - if: > > + properties: > > + compatible: > > + const: fsl,imx7ulp-usbphy > > + then: > > + required: > > + - nxp,sim > > + else: > > + properties: > > + nxp,sim: false > > + > > additionalProperties: false > > > > examples: > > > Could you please pick up patch #3? Rest of the patches are mainlined. Can you please resend it as an individual patch with the reviewed-by added to it? thanks, greg k-h
On Tue, Sep 03, 2024 at 09:08:52AM +0200, Greg KH wrote: > On Thu, Aug 29, 2024 at 05:09:35PM +0800, Xu Yang wrote: > > Hi Greg, > > > > On Fri, Jul 26, 2024 at 07:32:04PM +0800, Xu Yang wrote: > > > i.MX7ULP need properly set System Integration Module(SIM) module to make > > > usb wakeup work well. This will add a "nxp,sim" property. > > > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > > > --- > > > Changes in v2: > > > - add else branch suggested by Rob > > > --- > > > .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 +++++++++++++++++ > > > 1 file changed, 17 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > > index f4b1ca2fb562..ce665a2779b7 100644 > > > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml > > > @@ -87,6 +87,12 @@ properties: > > > maximum: 119 > > > default: 100 > > > > > > + nxp,sim: > > > + description: > > > + The system integration module (SIM) provides system control and chip > > > + configuration registers. > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + > > > required: > > > - compatible > > > - reg > > > @@ -110,6 +116,17 @@ allOf: > > > required: > > > - fsl,anatop > > > > > > + - if: > > > + properties: > > > + compatible: > > > + const: fsl,imx7ulp-usbphy > > > + then: > > > + required: > > > + - nxp,sim > > > + else: > > > + properties: > > > + nxp,sim: false > > > + > > > additionalProperties: false > > > > > > examples: > > > > > > Could you please pick up patch #3? Rest of the patches are mainlined. > > Can you please resend it as an individual patch with the reviewed-by > added to it? Sure. Will do it later. Thanks, Xu Yang
diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml index f4b1ca2fb562..ce665a2779b7 100644 --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml @@ -87,6 +87,12 @@ properties: maximum: 119 default: 100 + nxp,sim: + description: + The system integration module (SIM) provides system control and chip + configuration registers. + $ref: /schemas/types.yaml#/definitions/phandle + required: - compatible - reg @@ -110,6 +116,17 @@ allOf: required: - fsl,anatop + - if: + properties: + compatible: + const: fsl,imx7ulp-usbphy + then: + required: + - nxp,sim + else: + properties: + nxp,sim: false + additionalProperties: false examples:
i.MX7ULP need properly set System Integration Module(SIM) module to make usb wakeup work well. This will add a "nxp,sim" property. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v2: - add else branch suggested by Rob --- .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)