| Message ID | 20240807-b4-v6-10-topic-usb-onboard-dev-v1-2-f33ce21353c9@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | External VBUS port power handling for onboard USB devices | expand |
On Wed, Aug 07, 2024 at 04:36:52PM +0200, Marco Felsch wrote: > Some PCB designs don't connect the USB hub port power control GPIO and > instead make use of an host controllable regulator. Add support for this > use-case by introducing an portX-vbus-supply property. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > index 783c27591e56..51d02c4b8f2d 100644 > --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > @@ -35,6 +35,13 @@ required: > - compatible > - reg > > +patternProperties: > + "^port[1-7]-vbus-supply$" > + type: object > + description: > + Regulator controlling the USB VBUS on portX. Only required if the host > + controls the portX VBUS. This is completely external to the Microchip part, right? I think each port node should have a 'vbus-supply' property instead. Rob
Hi Rob, On 24-08-13, Rob Herring wrote: > On Wed, Aug 07, 2024 at 04:36:52PM +0200, Marco Felsch wrote: > > Some PCB designs don't connect the USB hub port power control GPIO and > > instead make use of an host controllable regulator. Add support for this > > use-case by introducing an portX-vbus-supply property. > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > --- > > Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > > index 783c27591e56..51d02c4b8f2d 100644 > > --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > > +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > > @@ -35,6 +35,13 @@ required: > > - compatible > > - reg > > > > +patternProperties: > > + "^port[1-7]-vbus-supply$" > > + type: object > > + description: > > + Regulator controlling the USB VBUS on portX. Only required if the host > > + controls the portX VBUS. > > This is completely external to the Microchip part, right? > > I think each port node should have a 'vbus-supply' property instead. This was my first approach but the problem is that we currently don't support such use-case: parent-node { /* Parent controlling the supply of the child node */ child-node { vbus-supply = <®>; }; }; at least I didn't found such use-case. I'm happy for pointers if you know more :) At the moment *-supply properties and device-nodes are bound together: parent-node { vbus-supply = <®>; }; Regards, Marco > > Rob >
diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml index 783c27591e56..51d02c4b8f2d 100644 --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml @@ -35,6 +35,13 @@ required: - compatible - reg +patternProperties: + "^port[1-7]-vbus-supply$" + type: object + description: + Regulator controlling the USB VBUS on portX. Only required if the host + controls the portX VBUS. + unevaluatedProperties: false examples:
Some PCB designs don't connect the USB hub port power control GPIO and instead make use of an host controllable regulator. Add support for this use-case by introducing an portX-vbus-supply property. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++ 1 file changed, 7 insertions(+)