diff mbox series

[v2] usb: core: sysfs: Unmerge @usb3_hardware_lpm_attr_group in remove_power_attributes()

Message ID 20240820-sysfs_fix-v2-1-a9441487077e@quicinc.com (mailing list archive)
State Accepted
Commit 3a8839bbb86da7968a792123ed2296d063871a52
Headers show
Series [v2] usb: core: sysfs: Unmerge @usb3_hardware_lpm_attr_group in remove_power_attributes() | expand

Commit Message

Zijun Hu Aug. 20, 2024, 11:01 a.m. UTC 
From: Zijun Hu <quic_zijuhu@quicinc.com>

Device attribute group @usb3_hardware_lpm_attr_group is merged by
add_power_attributes(), but it is not unmerged explicitly, fixed by
unmerging it in remove_power_attributes().

Fixes: 655fe4effe0f ("usbcore: add sysfs support to xHCI usb3 hardware LPM")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
Changes in v2:
- Add stable tag
- Link to v1: https://lore.kernel.org/r/20240814-sysfs_fix-v1-1-2224a29a259b@quicinc.com
---
 drivers/usb/core/sysfs.c | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: ca7df2c7bb5f83fe46aa9ce998b7352c6b28f3a1
change-id: 20240814-sysfs_fix-2206de9b0179

Best regards,
diff mbox series

Patch

diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
index d83231d6736a..61b6d978892c 100644
--- a/drivers/usb/core/sysfs.c
+++ b/drivers/usb/core/sysfs.c
@@ -670,6 +670,7 @@  static int add_power_attributes(struct device *dev)
 
 static void remove_power_attributes(struct device *dev)
 {
+	sysfs_unmerge_group(&dev->kobj, &usb3_hardware_lpm_attr_group);
 	sysfs_unmerge_group(&dev->kobj, &usb2_hardware_lpm_attr_group);
 	sysfs_unmerge_group(&dev->kobj, &power_attr_group);
 }