| Message ID | 20240910101527.603452-3-ukaszb@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: typec: Implement UCSI driver for ChromeOS | expand |
On Tue, Sep 10, 2024 at 10:15:21AM +0000, Łukasz Bartosik wrote: > From: Pavan Holla <pholla@chromium.org> > > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > driver. Also, add any feature flags that are implemented by the EC > but are missing in the kernel header. > > Signed-off-by: Pavan Holla <pholla@chromium.org> > Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org> Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
On Tue, 10 Sep 2024, Łukasz Bartosik wrote: > From: Pavan Holla <pholla@chromium.org> > > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > driver. Also, add any feature flags that are implemented by the EC > but are missing in the kernel header. > > Signed-off-by: Pavan Holla <pholla@chromium.org> > Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org> > --- > .../linux/platform_data/cros_ec_commands.h | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) Looks as though this is only used in the MFD patches which breaks without them. Can I take it without sending out a PR please?
On Fri, Oct 11, 2024 at 9:27 AM Lee Jones <lee@kernel.org> wrote: > > On Tue, 10 Sep 2024, Łukasz Bartosik wrote: > > > From: Pavan Holla <pholla@chromium.org> > > > > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > > driver. Also, add any feature flags that are implemented by the EC > > but are missing in the kernel header. > > > > Signed-off-by: Pavan Holla <pholla@chromium.org> > > Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org> > > --- > > .../linux/platform_data/cros_ec_commands.h | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > Looks as though this is only used in the MFD patches which breaks > without them. Can I take it without sending out a PR please? > Yes please take this patch. Thank you, Lukasz > -- > Lee Jones [李琼斯]
On Tue, 10 Sep 2024 10:15:21 +0000, Łukasz Bartosik wrote: > Define EC_FEATURE_UCSI_PPM to enable usage of the cros_ec_ucsi > driver. Also, add any feature flags that are implemented by the EC > but are missing in the kernel header. > > Applied, thanks! [2/8] platform/chrome: Update EC feature flags commit: 04a6116a36dfb86c80c930aaa03c66c2deb8e434 -- Lee Jones [李琼斯]
diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h index 8dbb6a769e4f..ecf290a0c98f 100644 --- a/include/linux/platform_data/cros_ec_commands.h +++ b/include/linux/platform_data/cros_ec_commands.h @@ -1312,6 +1312,38 @@ enum ec_feature_code { * The EC supports the AP composing VDMs for us to send. */ EC_FEATURE_TYPEC_AP_VDM_SEND = 46, + /* + * The EC supports system safe mode panic recovery. + */ + EC_FEATURE_SYSTEM_SAFE_MODE = 47, + /* + * The EC will reboot on runtime assertion failures. + */ + EC_FEATURE_ASSERT_REBOOTS = 48, + /* + * The EC image is built with tokenized logging enabled. + */ + EC_FEATURE_TOKENIZED_LOGGING = 49, + /* + * The EC supports triggering an STB dump. + */ + EC_FEATURE_AMD_STB_DUMP = 50, + /* + * The EC supports memory dump commands. + */ + EC_FEATURE_MEMORY_DUMP = 51, + /* + * The EC supports DP2.1 capability + */ + EC_FEATURE_TYPEC_DP2_1 = 52, + /* + * The MCU is System Companion Processor Core 1 + */ + EC_FEATURE_SCP_C1 = 53, + /* + * The EC supports UCSI PPM. + */ + EC_FEATURE_UCSI_PPM = 54, }; #define EC_FEATURE_MASK_0(event_code) BIT(event_code % 32)