diff mbox series

usb: storage: ignore bogus device raised by JieLi BR21 USB sound chip

Message ID 20241001083407.8336-1-uwu@icenowy.me (mailing list archive)
State Accepted
Commit a6555cb1cb69db479d0760e392c175ba32426842
Headers show
Series usb: storage: ignore bogus device raised by JieLi BR21 USB sound chip | expand

Commit Message

Icenowy Zheng Oct. 1, 2024, 8:34 a.m. UTC
JieLi tends to use SCSI via USB Mass Storage to implement their own
proprietary commands instead of implementing another USB interface.
Enumerating it as a generic mass storage device will lead to a Hardware
Error sense key get reported.

Ignore this bogus device to prevent appearing a unusable sdX device
file.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
---
 drivers/usb/storage/unusual_devs.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Alan Stern Oct. 1, 2024, 1:35 p.m. UTC | #1
On Tue, Oct 01, 2024 at 04:34:07PM +0800, Icenowy Zheng wrote:
> JieLi tends to use SCSI via USB Mass Storage to implement their own
> proprietary commands instead of implementing another USB interface.

What a strange thing to do.  I wonder why they chose that approach?

> Enumerating it as a generic mass storage device will lead to a Hardware
> Error sense key get reported.
> 
> Ignore this bogus device to prevent appearing a unusable sdX device
> file.
> 
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>

>  drivers/usb/storage/unusual_devs.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index fd68204374f2c..e5ad23d86833d 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2423,6 +2423,17 @@ UNUSUAL_DEV(  0xc251, 0x4003, 0x0100, 0x0100,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_NOT_LOCKABLE),
>  
> +/*
> + * Reported by Icenowy Zheng <uwu@icenowy.me>
> + * This is an interface for vendor-specific cryptic commands instead
> + * of real USB storage device.
> + */
> +UNUSUAL_DEV(  0xe5b7, 0x0811, 0x0100, 0x0100,
> +		"ZhuHai JieLi Technology",
> +		"JieLi BR21",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_IGNORE_DEVICE),
> +
>  /* Reported by Andrew Simmons <andrew.simmons@gmail.com> */
>  UNUSUAL_DEV(  0xed06, 0x4500, 0x0001, 0x0001,
>  		"DataStor",
> -- 
> 2.46.2
>
diff mbox series

Patch

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index fd68204374f2c..e5ad23d86833d 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -2423,6 +2423,17 @@  UNUSUAL_DEV(  0xc251, 0x4003, 0x0100, 0x0100,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_NOT_LOCKABLE),
 
+/*
+ * Reported by Icenowy Zheng <uwu@icenowy.me>
+ * This is an interface for vendor-specific cryptic commands instead
+ * of real USB storage device.
+ */
+UNUSUAL_DEV(  0xe5b7, 0x0811, 0x0100, 0x0100,
+		"ZhuHai JieLi Technology",
+		"JieLi BR21",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_IGNORE_DEVICE),
+
 /* Reported by Andrew Simmons <andrew.simmons@gmail.com> */
 UNUSUAL_DEV(  0xed06, 0x4500, 0x0001, 0x0001,
 		"DataStor",