| Message ID | 20241112-x1e80100-ps8830-v5-4-4ad83af4d162@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: typec: Add new driver for Parade PS8830 Type-C Retimer | expand |
On 24-11-12 19:01:13, Abel Vesa wrote: > The X Elite CRD provides external DisplayPort on all 3 USB Type-C ports. > Each one of this ports is connected to a dedicated DisplayPort > controller. > > Due to support missing in the USB/DisplayPort combo PHY driver, > the external DisplayPort is limited to 2 lanes. > > So enable all 3 remaining DisplayPort controllers and limit their data > lanes number to 2. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Please do not merge this specific patch. It is provided just for context and testing purposes. See the cover note for more details. > --- > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > index 659520404adec33c3551f8d0a5ae3db9e0a18d44..6dc2ebbf6d27fbbf0f224e58cd39ffd33792c6a1 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > @@ -1125,6 +1125,30 @@ &mdss { > status = "okay"; > }; > > +&mdss_dp0 { > + status = "okay"; > +}; > + > +&mdss_dp0_out { > + data-lanes = <0 1>; > +}; > + > +&mdss_dp1 { > + status = "okay"; > +}; > + > +&mdss_dp1_out { > + data-lanes = <0 1>; > +}; > + > +&mdss_dp2 { > + status = "okay"; > +}; > + > +&mdss_dp2_out { > + data-lanes = <0 1>; > +}; > + > &mdss_dp3 { > compatible = "qcom,x1e80100-dp"; > /delete-property/ #sound-dai-cells; > > -- > 2.34.1 >
On Tue, Nov 12, 2024 at 07:05:29PM +0200, Abel Vesa wrote: > On 24-11-12 19:01:13, Abel Vesa wrote: > > The X Elite CRD provides external DisplayPort on all 3 USB Type-C ports. > > Each one of this ports is connected to a dedicated DisplayPort > > controller. > > > > Due to support missing in the USB/DisplayPort combo PHY driver, > > the external DisplayPort is limited to 2 lanes. > > > > So enable all 3 remaining DisplayPort controllers and limit their data > > lanes number to 2. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > Please do not merge this specific patch. Please do not mix patches that should, and should not, be applied in the same series as that plays havoc with our tools that want to take a whole series at once. Stuff like this just makes me delete the whole series from my review queue, and if you got sent something like this, I imagine you would do the same :( thanks, greg k-h
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index 659520404adec33c3551f8d0a5ae3db9e0a18d44..6dc2ebbf6d27fbbf0f224e58cd39ffd33792c6a1 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -1125,6 +1125,30 @@ &mdss { status = "okay"; }; +&mdss_dp0 { + status = "okay"; +}; + +&mdss_dp0_out { + data-lanes = <0 1>; +}; + +&mdss_dp1 { + status = "okay"; +}; + +&mdss_dp1_out { + data-lanes = <0 1>; +}; + +&mdss_dp2 { + status = "okay"; +}; + +&mdss_dp2_out { + data-lanes = <0 1>; +}; + &mdss_dp3 { compatible = "qcom,x1e80100-dp"; /delete-property/ #sound-dai-cells;
The X Elite CRD provides external DisplayPort on all 3 USB Type-C ports. Each one of this ports is connected to a dedicated DisplayPort controller. Due to support missing in the USB/DisplayPort combo PHY driver, the external DisplayPort is limited to 2 lanes. So enable all 3 remaining DisplayPort controllers and limit their data lanes number to 2. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)