| Message ID | 20241218052214.1808006-1-miao@synopsys.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On 18/12/2024 06:22, Miao.Zhu wrote: > From: Miao Zhu <miao@synopsys.com> > > The TCPCI driver has flags to configure its protperties but > no way to enable these flags yet. Add these flags into DT > so that the driver can be compatible with TCPCI Spec R2 V1.0. Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument, so you will not CC people just because they made one commit years ago). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. </form letter> > > Signed-off-by: Miao.Zhu <miao@synopsys.com> > --- > V2 -> V3: Add description and type for new properties: > --- > .../devicetree/bindings/usb/nxp,ptn5110.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > index 65a8632..29d6aed 100644 > --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > @@ -21,6 +21,28 @@ properties: > interrupts: > maxItems: 1 > > + TX_BUF_BYTE_x_hidden: Follow DTS coding style. > + description: > + When set, TX_BUF_BYTE_x can only be accessed through > + I2C_WRITE_BYTE_COUNT. You described the desired Linux feature or behavior, not the actual hardware. The bindings are about the latter, so instead you need to rephrase the property and its description to match actual hardware capabilities/features/configuration etc. Best regards, Krzysztof
On 18/12/2024 09:04, Krzysztof Kozlowski wrote: >> interrupts: >> maxItems: 1 >> >> + TX_BUF_BYTE_x_hidden: > > Follow DTS coding style. > >> + description: >> + When set, TX_BUF_BYTE_x can only be accessed through >> + I2C_WRITE_BYTE_COUNT. > You described the desired Linux feature or behavior, not the actual > hardware. The bindings are about the latter, so instead you need to > rephrase the property and its description to match actual hardware > capabilities/features/configuration etc. I forgot: missing vendor prefix, missing type. Please see how other bindings are written. example-schema is also good to start with. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml index 65a8632..29d6aed 100644 --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml @@ -21,6 +21,28 @@ properties: interrupts: maxItems: 1 + TX_BUF_BYTE_x_hidden: + description: + When set, TX_BUF_BYTE_x can only be accessed through + I2C_WRITE_BYTE_COUNT. + type: boolean + + RX_BUF_BYTE_x_hidden: + description: + When set, RX_BUF_BYTE_x can only be accessed through + READABLE_BYTE_COUNT. + type: boolean + + auto_discharge_disconnect: + description: + When set, TCPC autonomously discharges vbus on disconnect. + type: boolean + + vbus_vsafe0v: + description: + When set, TCPC can detect whether vbus is at VSAFE0V. + type: boolean + connector: type: object $ref: /schemas/connector/usb-connector.yaml#