diff mbox series

[v2] Update USB/IP OP_REP_IMPORT documentation.

Message ID 20241224062336.63215-1-gordon.xwj@gmail.com (mailing list archive)
State New
Headers show
Series [v2] Update USB/IP OP_REP_IMPORT documentation. | expand

Commit Message

Gordon Ou Dec. 24, 2024, 6:23 a.m. UTC 
This is to correct the mistaken byte offset of the field bDeviceClass in
OP_REP_IMPORT documentation. The previous field bcdDevice has length 2 and
the offset for bDeviceClass should be 0x138 + 2 = 0x13A instead of 0x139.
Offsets for subsequent fields are also affected and fixed in this patch.

Signed-off-by: Gordon Ou <gordon.xwj@gmail.com>
---
Changes in v2:
 - Updated patch description.
---
 Documentation/usb/usbip_protocol.rst | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Shuah Khan Dec. 26, 2024, 6:28 p.m. UTC | #1 
On 12/23/24 23:23, Gordon Ou wrote:
> This is to correct the mistaken byte offset of the field bDeviceClass in
> OP_REP_IMPORT documentation. The previous field bcdDevice has length 2 and
> the offset for bDeviceClass should be 0x138 + 2 = 0x13A instead of 0x139.
> Offsets for subsequent fields are also affected and fixed in this patch.
> 
> Signed-off-by: Gordon Ou <gordon.xwj@gmail.com>
> ---
> Changes in v2:
>   - Updated patch description.

Looks good to me.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

Greg, please pick this up.

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/Documentation/usb/usbip_protocol.rst b/Documentation/usb/usbip_protocol.rst
index adc158967cc6..3da1df3d94f5 100644
--- a/Documentation/usb/usbip_protocol.rst
+++ b/Documentation/usb/usbip_protocol.rst
@@ -285,17 +285,17 @@  OP_REP_IMPORT:
 +-----------+--------+------------+---------------------------------------------------+
 | 0x138     | 2      |            | bcdDevice                                         |
 +-----------+--------+------------+---------------------------------------------------+
-| 0x139     | 1      |            | bDeviceClass                                      |
+| 0x13A     | 1      |            | bDeviceClass                                      |
 +-----------+--------+------------+---------------------------------------------------+
-| 0x13A     | 1      |            | bDeviceSubClass                                   |
+| 0x13B     | 1      |            | bDeviceSubClass                                   |
 +-----------+--------+------------+---------------------------------------------------+
-| 0x13B     | 1      |            | bDeviceProtocol                                   |
+| 0x13C     | 1      |            | bDeviceProtocol                                   |
 +-----------+--------+------------+---------------------------------------------------+
-| 0x13C     | 1      |            | bConfigurationValue                               |
+| 0x13D     | 1      |            | bConfigurationValue                               |
 +-----------+--------+------------+---------------------------------------------------+
-| 0x13D     | 1      |            | bNumConfigurations                                |
+| 0x13E     | 1      |            | bNumConfigurations                                |
 +-----------+--------+------------+---------------------------------------------------+
-| 0x13E     | 1      |            | bNumInterfaces                                    |
+| 0x13F     | 1      |            | bNumInterfaces                                    |
 +-----------+--------+------------+---------------------------------------------------+
 
 The following four commands have a common basic header called