Message ID | 20250108101518.30607-1-johan@kernel.org (mailing list archive) |
---|---|
State | Accepted |
Commit | 138a99ca4e20fa1e17b4e59fa053981913702d6d |
Headers | show |
Series | USB: serial: ch341: use fix-width types consistently | expand |
On Wed, Jan 08, 2025 at 11:15:18AM +0100, Johan Hovold wrote: > Use Linux fix-width types consistently and drop a related unnecessary > cast. > > Signed-off-by: Johan Hovold <johan@kernel.org> > --- > drivers/usb/serial/ch341.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c > index ac74b353b26d..7cc36f84821f 100644 > --- a/drivers/usb/serial/ch341.c > +++ b/drivers/usb/serial/ch341.c > @@ -660,13 +660,12 @@ static int ch341_simulate_break(struct tty_struct *tty, int break_state) > > static int ch341_break_ctl(struct tty_struct *tty, int break_state) > { > - const uint16_t ch341_break_reg = > - ((uint16_t) CH341_REG_LCR << 8) | CH341_REG_BREAK; > + const u16 ch341_break_reg = (CH341_REG_LCR << 8) | CH341_REG_BREAK; > struct usb_serial_port *port = tty->driver_data; > struct ch341_private *priv = usb_get_serial_port_data(port); > + u16 reg_contents; > + u8 break_reg[2]; > int r; > - uint16_t reg_contents; > - uint8_t break_reg[2]; > > if (priv->quirks & CH341_QUIRK_SIMULATE_BREAK) > return ch341_simulate_break(tty, break_state); > -- > 2.45.2 > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index ac74b353b26d..7cc36f84821f 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c @@ -660,13 +660,12 @@ static int ch341_simulate_break(struct tty_struct *tty, int break_state) static int ch341_break_ctl(struct tty_struct *tty, int break_state) { - const uint16_t ch341_break_reg = - ((uint16_t) CH341_REG_LCR << 8) | CH341_REG_BREAK; + const u16 ch341_break_reg = (CH341_REG_LCR << 8) | CH341_REG_BREAK; struct usb_serial_port *port = tty->driver_data; struct ch341_private *priv = usb_get_serial_port_data(port); + u16 reg_contents; + u8 break_reg[2]; int r; - uint16_t reg_contents; - uint8_t break_reg[2]; if (priv->quirks & CH341_QUIRK_SIMULATE_BREAK) return ch341_simulate_break(tty, break_state);
Use Linux fix-width types consistently and drop a related unnecessary cast. Signed-off-by: Johan Hovold <johan@kernel.org> --- drivers/usb/serial/ch341.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)