| Message ID | 20250116153829.477360-1-jonathanh@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 983e375849fe4fd987cab94d940ba2af6f9e7a71 |
| Headers | show |
| Series | usb: xhci: tegra: Fix OF boolean read warning | expand |
On Thu, Jan 16, 2025 at 03:38:29PM +0000, Jon Hunter wrote: > After commit c141ecc3cecd ("of: Warn when of_property_read_bool() is > used on non-boolean properties") was added, the following warning is > observed for the Tegra XHCI driver ... > > OF: /bus@0/usb@3610000: Read of boolean property 'power-domains' with > a value. > > Previously, of_property_read_bool() was used to determine if a property > was present but has now been replaced by of_property_present(). The > warning is meant to prevent new users but this user existed before the > change was made. Fix this by updating the Tegra XHCI driver to use > of_property_present() function to determine if the 'power-domains' > property is present. > > Fixes: c141ecc3cecd ("of: Warn when of_property_read_bool() is used on non-boolean properties") > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > drivers/usb/host/xhci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding <treding@nvidia.com>
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c index 06ae193ec874..7ac341b3599a 100644 --- a/drivers/usb/host/xhci-tegra.c +++ b/drivers/usb/host/xhci-tegra.c @@ -1667,7 +1667,7 @@ static int tegra_xusb_probe(struct platform_device *pdev) goto put_padctl; } - if (!of_property_read_bool(pdev->dev.of_node, "power-domains")) { + if (!of_property_present(pdev->dev.of_node, "power-domains")) { tegra->host_rst = devm_reset_control_get(&pdev->dev, "xusb_host"); if (IS_ERR(tegra->host_rst)) {
After commit c141ecc3cecd ("of: Warn when of_property_read_bool() is used on non-boolean properties") was added, the following warning is observed for the Tegra XHCI driver ... OF: /bus@0/usb@3610000: Read of boolean property 'power-domains' with a value. Previously, of_property_read_bool() was used to determine if a property was present but has now been replaced by of_property_present(). The warning is meant to prevent new users but this user existed before the change was made. Fix this by updating the Tegra XHCI driver to use of_property_present() function to determine if the 'power-domains' property is present. Fixes: c141ecc3cecd ("of: Warn when of_property_read_bool() is used on non-boolean properties") Signed-off-by: Jon Hunter <jonathanh@nvidia.com> --- drivers/usb/host/xhci-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)