| Message ID | 20250116154117.148915-4-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: dwc3: Avoid using reserved EPs | expand |
On Thu, Jan 16, 2025, Andy Shevchenko wrote: > Intel Merrifield SoC uses these endpoints for tracing and they shouldn't > be used for normal transfers, we need to skip them. > > • 1 High BW Bulk IN (IN#1) (RTIT) > • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8) > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/usb/dwc3/dwc3-pci.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c > index 052852f80146..9b73dfd34823 100644 > --- a/drivers/usb/dwc3/dwc3-pci.c > +++ b/drivers/usb/dwc3/dwc3-pci.c > @@ -148,11 +148,20 @@ static const struct property_entry dwc3_pci_intel_byt_properties[] = { > {} > }; > > +/* > + * Intel Merrifield uses these endpoints for tracing and they shouldn't be used > + * for normal transfers, we need to skip them. > + * • 1 High BW Bulk IN (IN#1) (RTIT) > + * • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8) Please use regular bullet character and list the endpoint per line. BR, Thinh > + */ > +static const u8 dwc3_pci_mrfld_reserved_endpoints[] = { 3, 16, 17 }; > + > static const struct property_entry dwc3_pci_mrfld_properties[] = { > PROPERTY_ENTRY_STRING("dr_mode", "otg"), > PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"), > PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"), > PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"), > + PROPERTY_ENTRY_U8_ARRAY("snps,reserved-endpoints", dwc3_pci_mrfld_reserved_endpoints), > PROPERTY_ENTRY_BOOL("snps,usb2-gadget-lpm-disable"), > PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"), > {} > -- > 2.43.0.rc1.1336.g36b5255a03ac >
On Thu, Jan 16, 2025 at 11:39:42PM +0000, Thinh Nguyen wrote: > On Thu, Jan 16, 2025, Andy Shevchenko wrote: ... > > + * Intel Merrifield uses these endpoints for tracing and they shouldn't be used > > + * for normal transfers, we need to skip them. > > + * • 1 High BW Bulk IN (IN#1) (RTIT) > > + * • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8) > > Please use regular bullet character and list the endpoint per line. Which is...? To my curiosity, what's wrong with the above?
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 052852f80146..9b73dfd34823 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -148,11 +148,20 @@ static const struct property_entry dwc3_pci_intel_byt_properties[] = { {} }; +/* + * Intel Merrifield uses these endpoints for tracing and they shouldn't be used + * for normal transfers, we need to skip them. + * • 1 High BW Bulk IN (IN#1) (RTIT) + * • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8) + */ +static const u8 dwc3_pci_mrfld_reserved_endpoints[] = { 3, 16, 17 }; + static const struct property_entry dwc3_pci_mrfld_properties[] = { PROPERTY_ENTRY_STRING("dr_mode", "otg"), PROPERTY_ENTRY_STRING("linux,extcon-name", "mrfld_bcove_pwrsrc"), PROPERTY_ENTRY_BOOL("snps,dis_u3_susphy_quirk"), PROPERTY_ENTRY_BOOL("snps,dis_u2_susphy_quirk"), + PROPERTY_ENTRY_U8_ARRAY("snps,reserved-endpoints", dwc3_pci_mrfld_reserved_endpoints), PROPERTY_ENTRY_BOOL("snps,usb2-gadget-lpm-disable"), PROPERTY_ENTRY_BOOL("linux,sysdev_is_parent"), {}
Intel Merrifield SoC uses these endpoints for tracing and they shouldn't be used for normal transfers, we need to skip them. • 1 High BW Bulk IN (IN#1) (RTIT) • 1 1KB BW Bulk IN (IN#8) + 1 1KB BW Bulk OUT (Run Control) (OUT#8) Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/usb/dwc3/dwc3-pci.c | 9 +++++++++ 1 file changed, 9 insertions(+)