| Message ID | 20250203-defer_usb1-v1-1-f6bba254215d@atmark-techno.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: usb251xb: silence EPROBE_DEFER error on boot | expand |
Le 03/02/2025 à 07:08, Dominique Martinet a écrit : > Use dev_err_probe to silence EPROBE_DEFER error on boot: > [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517 > > Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> > --- > drivers/usb/misc/usb251xb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c > index e24cdb667307802b9eee856e20744ebf694395e8..ed7c99621fc9af57c988b2298a576248b329ba3d 100644 > --- a/drivers/usb/misc/usb251xb.c > +++ b/drivers/usb/misc/usb251xb.c > @@ -637,8 +637,7 @@ static int usb251xb_probe(struct usb251xb *hub) > if (np && usb_data) { > err = usb251xb_get_ofdata(hub, usb_data); > if (err) { > - dev_err(dev, "failed to get ofdata: %d\n", err); > - return err; > + return dev_err_probe(dev, err, "failed to get ofdata: %d\n", err); : %d\n", err should be removed now. The error code will already be added in the message in a human readable way. CJ > } > } > > > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250203-defer_usb1-254070d18cc9 > > Best regards,
Le 03/02/2025 à 07:08, Dominique Martinet a écrit : > Use dev_err_probe to silence EPROBE_DEFER error on boot: > [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517 > > Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> > --- > drivers/usb/misc/usb251xb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c > index e24cdb667307802b9eee856e20744ebf694395e8..ed7c99621fc9af57c988b2298a576248b329ba3d 100644 > --- a/drivers/usb/misc/usb251xb.c > +++ b/drivers/usb/misc/usb251xb.c > @@ -637,8 +637,7 @@ static int usb251xb_probe(struct usb251xb *hub) > if (np && usb_data) { > err = usb251xb_get_ofdata(hub, usb_data); > if (err) { > - dev_err(dev, "failed to get ofdata: %d\n", err); > - return err; > + return dev_err_probe(dev, err, "failed to get ofdata: %d\n", err); > } extra { } can also be removed now that there is only 1 line left. CJ > } > > > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250203-defer_usb1-254070d18cc9 > > Best regards,
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index e24cdb667307802b9eee856e20744ebf694395e8..ed7c99621fc9af57c988b2298a576248b329ba3d 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -637,8 +637,7 @@ static int usb251xb_probe(struct usb251xb *hub) if (np && usb_data) { err = usb251xb_get_ofdata(hub, usb_data); if (err) { - dev_err(dev, "failed to get ofdata: %d\n", err); - return err; + return dev_err_probe(dev, err, "failed to get ofdata: %d\n", err); } }
Use dev_err_probe to silence EPROBE_DEFER error on boot: [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517 Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> --- drivers/usb/misc/usb251xb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250203-defer_usb1-254070d18cc9 Best regards,