| Message ID | 20250203-defer_usb1-v2-1-eba405ebee2c@atmark-techno.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 42bc7faaf3a0da2adff71e292efe3eb428018c07 |
| Headers | show |
| Series | [v2] usb: usb251xb: silence EPROBE_DEFER error on boot | expand |
On Mon, Feb 03, 2025 at 03:33:49PM +0900, Dominique Martinet wrote: > Use dev_err_probe to silence EPROBE_DEFER error on boot: > [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517 > > Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> > --- > Changes in v2: > - removed redundant error code in message and brace > - Link to v1: https://lore.kernel.org/r/20250203-defer_usb1-v1-1-f6bba254215d@atmark-techno.com > --- > drivers/usb/misc/usb251xb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c > index e24cdb667307802b9eee856e20744ebf694395e8..4fb453ca545013f8b89c43d3bb5cc6d1c53b39c9 100644 > --- a/drivers/usb/misc/usb251xb.c > +++ b/drivers/usb/misc/usb251xb.c > @@ -636,10 +636,8 @@ static int usb251xb_probe(struct usb251xb *hub) > > if (np && usb_data) { > err = usb251xb_get_ofdata(hub, usb_data); > - if (err) { > - dev_err(dev, "failed to get ofdata: %d\n", err); > - return err; > - } > + if (err) > + return dev_err_probe(dev, err, "failed to get ofdata\n"); > } > > /* > > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250203-defer_usb1-254070d18cc9 Acked-by: Richard Leitner <richard.leitner@linux.dev>
diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c index e24cdb667307802b9eee856e20744ebf694395e8..4fb453ca545013f8b89c43d3bb5cc6d1c53b39c9 100644 --- a/drivers/usb/misc/usb251xb.c +++ b/drivers/usb/misc/usb251xb.c @@ -636,10 +636,8 @@ static int usb251xb_probe(struct usb251xb *hub) if (np && usb_data) { err = usb251xb_get_ofdata(hub, usb_data); - if (err) { - dev_err(dev, "failed to get ofdata: %d\n", err); - return err; - } + if (err) + return dev_err_probe(dev, err, "failed to get ofdata\n"); } /*
Use dev_err_probe to silence EPROBE_DEFER error on boot: [ 0.757677] usb251xb 1-002c: failed to get ofdata: -517 Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> --- Changes in v2: - removed redundant error code in message and brace - Link to v1: https://lore.kernel.org/r/20250203-defer_usb1-v1-1-f6bba254215d@atmark-techno.com --- drivers/usb/misc/usb251xb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250203-defer_usb1-254070d18cc9 Best regards,