| Message ID | 20250213060804.114558-1-412574090@163.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: fix error while OF and ACPI all config Y | expand |
On 2/13/25 9:08 AM, 412574090@163.com wrote: > From: weiyufeng <weiyufeng@kylinos.cn> > > When both OF and ACPI are configured as Y simultaneously，this may > cause error while install os with usb disk，while reading data from > the usb disk, the onboard_ hub driver will reinitialize the > hub, causing system installation exceptions. > > Signed-off-by: weiyufeng <weiyufeng@kylinos.cn> > --- > drivers/usb/misc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig > index 6497c4e81e95..9ffb51191621 100644 > --- a/drivers/usb/misc/Kconfig > +++ b/drivers/usb/misc/Kconfig > @@ -318,7 +318,7 @@ config BRCM_USB_PINMAP > > config USB_ONBOARD_DEV > tristate "Onboard USB device support" > - depends on OF > + depends on (OF && !ACPI) I don't think () are needed here. [...] MBR, Sergey
>> From: weiyufeng <weiyufeng@kylinos.cn> >> >> When both OF and ACPI are configured as Y simultaneously，this may >> cause error while install os with usb disk，while reading data from >> the usb disk, the onboard_ hub driver will reinitialize the >> hub, causing system installation exceptions. >> >> Signed-off-by: weiyufeng <weiyufeng@kylinos.cn> >> --- >> drivers/usb/misc/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig >> index 6497c4e81e95..9ffb51191621 100644 >> --- a/drivers/usb/misc/Kconfig >> +++ b/drivers/usb/misc/Kconfig >> @@ -318,7 +318,7 @@ config BRCM_USB_PINMAP >> >> config USB_ONBOARD_DEV >> tristate "Onboard USB device support" >> - depends on OF >> + depends on (OF && !ACPI) > > I don't think () are needed here. Yes, () will be deleted in next version. -- Thanks, weiyufeng
diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index 6497c4e81e95..9ffb51191621 100644 --- a/drivers/usb/misc/Kconfig +++ b/drivers/usb/misc/Kconfig @@ -318,7 +318,7 @@ config BRCM_USB_PINMAP config USB_ONBOARD_DEV tristate "Onboard USB device support" - depends on OF + depends on (OF && !ACPI) help Say Y here if you want to support discrete onboard USB devices that don't require an additional control bus for initialization,