[next,v3,1/3] dt-bindings: usb: microchip,usb2514: add support for vdda

Commit Message

Catalin Popescu Feb. 13, 2025, 9:43 a.m. UTC

Microchip hub USB2514 has one 3V3 digital power supply and one 3V3
analog power supply. Add support for analog power supply vdda.

Signed-off-by: Catalin Popescu <[e-mail]>
---
v3:
- replace "if then else" by "if not then"

v2:
- merge "if" with "allOf" and move the whole after patternProperties
  section
---
 .../bindings/usb/microchip,usb2514.yaml       | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)


base-commit: df5d6180169ae06a2eac57e33b077ad6f6252440
prerequisite-patch-id: 0000000000000000000000000000000000000000

Comments

Krzysztof Kozlowski Feb. 14, 2025, 8:15 a.m. UTC | #1

On Thu, Feb 13, 2025 at 10:43:36AM +0100, Catalin Popescu wrote:
> Microchip hub USB2514 has one 3V3 digital power supply and one 3V3
> analog power supply. Add support for analog power supply vdda.
> 
> Signed-off-by: Catalin Popescu <[e-mail]>
> ---
> v3:
> - replace "if then else" by "if not then"
> 
> v2:
> - merge "if" with "allOf" and move the whole after patternProperties
>   section
> ---
>  .../bindings/usb/microchip,usb2514.yaml       | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)

Reviewed-by: Krzysztof Kozlowski <[e-mail]>

Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
index b14e6f37b298..d0479beee30b 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
@@ -9,9 +9,6 @@  title: Microchip USB2514 Hub Controller
 maintainers:
   - Fabio Estevam <[e-mail]>
 
-allOf:
-  - $ref: usb-device.yaml#
-
 properties:
   compatible:
     enum:
@@ -28,6 +25,9 @@  properties:
   vdd-supply:
     description: 3.3V power supply.
 
+  vdda-supply:
+    description: 3.3V analog power supply.
+
   clocks:
     description: External 24MHz clock connected to the CLKIN pin.
     maxItems: 1
@@ -43,6 +43,18 @@  patternProperties:
     $ref: /schemas/usb/usb-device.yaml
     additionalProperties: true
 
+allOf:
+  - $ref: usb-device.yaml#
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              const: usb424,2514
+    then:
+      properties:
+        vdda-supply: false
+
 unevaluatedProperties: false
 
 examples:
@@ -60,6 +72,7 @@  examples:
             clocks = <&clks IMX6QDL_CLK_CKO>;
             reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
             vdd-supply = <&reg_3v3_hub>;
+            vdda-supply = <&reg_3v3a_hub>;
             #address-cells = <1>;
             #size-cells = <0>;