| Message ID | 20250216001609.106616-3-surajpatil522@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: typec: displayport: Update outdated FIXME comment | expand |
On Sun, Feb 16, 2025 at 12:16:09AM +0000, Suraj Patil wrote: > The port mode is intentionally fixed to DFP_U; remove the FIXME tag. Really? > > Signed-off-by: Suraj Patil <surajpatil522@gmail.com> > --- > drivers/usb/typec/altmodes/displayport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c > index ac84a6d64c2f..732ee9399921 100644 > --- a/drivers/usb/typec/altmodes/displayport.c > +++ b/drivers/usb/typec/altmodes/displayport.c > @@ -727,7 +727,7 @@ int dp_altmode_probe(struct typec_altmode *alt) > struct fwnode_handle *fwnode; > struct dp_altmode *dp; > > - /* FIXME: Port can only be DFP_U. */ > + /* Port mode is fixed to DFP_U. */ Are you sure this can be removed? I read this as this is a problem and needs to be fixed in the future sometime, why is this suddenly not a problem? What commit id fixed it? thanks, greg k-h
On Sun, Feb 16, 2025 at 04:03:47PM +0530, Suraj Patil wrote:
> Hi Greg,
Hi,
Please don't send html emails, or top-post, that way the message is not
dropped by the mailing list. I'll be glad to respond if you can do so
so that everyone else can see it.
thanks,
greg k-h
diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c index ac84a6d64c2f..732ee9399921 100644 --- a/drivers/usb/typec/altmodes/displayport.c +++ b/drivers/usb/typec/altmodes/displayport.c @@ -727,7 +727,7 @@ int dp_altmode_probe(struct typec_altmode *alt) struct fwnode_handle *fwnode; struct dp_altmode *dp; - /* FIXME: Port can only be DFP_U. */ + /* Port mode is fixed to DFP_U. */ /* Make sure we have compatible pin configurations */ if (!(DP_CAP_PIN_ASSIGN_DFP_D(port->vdo) &
The port mode is intentionally fixed to DFP_U; remove the FIXME tag. Signed-off-by: Suraj Patil <surajpatil522@gmail.com> --- drivers/usb/typec/altmodes/displayport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)