| Message ID | 20250310150835.3139322-5-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | leds: Introduce and use fwnode_get_child_node_count() | expand |
On Mon, 10 Mar 2025 16:54:54 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Since fwnode_get_child_node_count() was split from its device property > counterpart, we may utilise it in the driver and drop custom implementation. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Seems like a nice little series to me! Jonathan > --- > drivers/usb/typec/tcpm/tcpm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 9c455f073233..8ca2e26752fb 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -7166,7 +7166,7 @@ static void tcpm_fw_get_timings(struct tcpm_port *port, struct fwnode_handle *fw > > static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode) > { > - struct fwnode_handle *capabilities, *child, *caps = NULL; > + struct fwnode_handle *capabilities, *caps = NULL; > unsigned int nr_src_pdo, nr_snk_pdo; > const char *opmode_str; > u32 *src_pdo, *snk_pdo; > @@ -7232,9 +7232,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode > if (!capabilities) { > port->pd_count = 1; > } else { > - fwnode_for_each_child_node(capabilities, child) > - port->pd_count++; > - > + port->pd_count = fwnode_get_child_node_count(capabilities); > if (!port->pd_count) { > ret = -ENODATA; > goto put_capabilities;
On Mon, Mar 10, 2025 at 11:09 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Since fwnode_get_child_node_count() was split from its device property > counterpart, we may utilise it in the driver and drop custom implementation. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Kyle Tso <kyletso@google.com> > --- > drivers/usb/typec/tcpm/tcpm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 9c455f073233..8ca2e26752fb 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -7166,7 +7166,7 @@ static void tcpm_fw_get_timings(struct tcpm_port *port, struct fwnode_handle *fw > > static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode) > { > - struct fwnode_handle *capabilities, *child, *caps = NULL; > + struct fwnode_handle *capabilities, *caps = NULL; > unsigned int nr_src_pdo, nr_snk_pdo; > const char *opmode_str; > u32 *src_pdo, *snk_pdo; > @@ -7232,9 +7232,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode > if (!capabilities) { > port->pd_count = 1; > } else { > - fwnode_for_each_child_node(capabilities, child) > - port->pd_count++; > - > + port->pd_count = fwnode_get_child_node_count(capabilities); > if (!port->pd_count) { > ret = -ENODATA; > goto put_capabilities; > -- > 2.47.2 > >
On Mon, Mar 10, 2025 at 04:54:54PM +0200, Andy Shevchenko wrote: > Since fwnode_get_child_node_count() was split from its device property > counterpart, we may utilise it in the driver and drop custom implementation. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 9c455f073233..8ca2e26752fb 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -7166,7 +7166,7 @@ static void tcpm_fw_get_timings(struct tcpm_port *port, struct fwnode_handle *fw > > static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode) > { > - struct fwnode_handle *capabilities, *child, *caps = NULL; > + struct fwnode_handle *capabilities, *caps = NULL; > unsigned int nr_src_pdo, nr_snk_pdo; > const char *opmode_str; > u32 *src_pdo, *snk_pdo; > @@ -7232,9 +7232,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode > if (!capabilities) { > port->pd_count = 1; > } else { > - fwnode_for_each_child_node(capabilities, child) > - port->pd_count++; > - > + port->pd_count = fwnode_get_child_node_count(capabilities); > if (!port->pd_count) { > ret = -ENODATA; > goto put_capabilities; > -- > 2.47.2
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 9c455f073233..8ca2e26752fb 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -7166,7 +7166,7 @@ static void tcpm_fw_get_timings(struct tcpm_port *port, struct fwnode_handle *fw static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode) { - struct fwnode_handle *capabilities, *child, *caps = NULL; + struct fwnode_handle *capabilities, *caps = NULL; unsigned int nr_src_pdo, nr_snk_pdo; const char *opmode_str; u32 *src_pdo, *snk_pdo; @@ -7232,9 +7232,7 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode if (!capabilities) { port->pd_count = 1; } else { - fwnode_for_each_child_node(capabilities, child) - port->pd_count++; - + port->pd_count = fwnode_get_child_node_count(capabilities); if (!port->pd_count) { ret = -ENODATA; goto put_capabilities;
Since fwnode_get_child_node_count() was split from its device property counterpart, we may utilise it in the driver and drop custom implementation. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/usb/typec/tcpm/tcpm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)