| Message ID | 20250327120737.230041-2-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: renesas_usbhs: Reorder clock handling | expand |
Hi Prabhakar Thank you for your patch > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Update the comment to reference `usbhs_mod_probe` instead of > `usbhs_mod_init`, as `usbhs_mod_probe` is the correct function > used in this context. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > drivers/usb/renesas_usbhs/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > index 4b35ef216125..15ef246a1245 100644 > --- a/drivers/usb/renesas_usbhs/common.c > +++ b/drivers/usb/renesas_usbhs/common.c > @@ -698,7 +698,7 @@ static int usbhs_probe(struct platform_device *pdev) > if (ret < 0) > goto probe_end_fifo_exit; > > - /* dev_set_drvdata should be called after usbhs_mod_init */ > + /* dev_set_drvdata should be called after usbhs_mod_probe */ > platform_set_drvdata(pdev, priv); If you want to care about context, it seems we want to care "dev_set_drvdata" and "platform_set_drvdata" too :) And, it is easy to understand that it indicates function if it has (). like below - /* dev_set_drvdata should be called after usbhs_mod_init */ + /* platform_set_drvdata() should be called after usbhs_mod_probe() */ platform_set_drvdata(pdev, priv); Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Kuninori san, Thank you for the review. On Fri, Mar 28, 2025 at 12:09 AM Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > > Hi Prabhakar > > Thank you for your patch > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Update the comment to reference `usbhs_mod_probe` instead of > > `usbhs_mod_init`, as `usbhs_mod_probe` is the correct function > > used in this context. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > drivers/usb/renesas_usbhs/common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > > index 4b35ef216125..15ef246a1245 100644 > > --- a/drivers/usb/renesas_usbhs/common.c > > +++ b/drivers/usb/renesas_usbhs/common.c > > @@ -698,7 +698,7 @@ static int usbhs_probe(struct platform_device *pdev) > > if (ret < 0) > > goto probe_end_fifo_exit; > > > > - /* dev_set_drvdata should be called after usbhs_mod_init */ > > + /* dev_set_drvdata should be called after usbhs_mod_probe */ > > platform_set_drvdata(pdev, priv); > > If you want to care about context, it seems we want to care "dev_set_drvdata" > and "platform_set_drvdata" too :) > And, it is easy to understand that it indicates function if it has (). > like below > > - /* dev_set_drvdata should be called after usbhs_mod_init */ > + /* platform_set_drvdata() should be called after usbhs_mod_probe() */ > platform_set_drvdata(pdev, priv); > Ok, I'll update it as above in v2. Cheers, Prabhakar
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index 4b35ef216125..15ef246a1245 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -698,7 +698,7 @@ static int usbhs_probe(struct platform_device *pdev) if (ret < 0) goto probe_end_fifo_exit; - /* dev_set_drvdata should be called after usbhs_mod_init */ + /* dev_set_drvdata should be called after usbhs_mod_probe */ platform_set_drvdata(pdev, priv); ret = reset_control_deassert(priv->rsts);