| Message ID | 20250327172803.3404615-4-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add ext. port vbus handling for onboard-dev | expand |
On Thu, 27 Mar 2025 18:28:02 +0100, Marco Felsch wrote: > Some PCB designs don't connect the USB hub port power control GPIO and > instead make use of a host controllable regulator. Add support for this > use-case by introducing portX-vbus-supply property. > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > .../devicetree/bindings/usb/microchip,usb2514.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/microchip,usb2514.yaml:53:5: [error] syntax error: could not find expected ':' (syntax) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml: ignoring, error parsing file ./Documentation/devicetree/bindings/usb/microchip,usb2514.yaml:53:5: could not find expected ':' make[2]: *** Deleting file 'Documentation/devicetree/bindings/usb/microchip,usb2514.example.dts' Documentation/devicetree/bindings/usb/microchip,usb2514.yaml:53:5: could not find expected ':' make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/usb/microchip,usb2514.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1522: dt_binding_check] Error 2 make: *** [Makefile:248: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250327172803.3404615-4-m.felsch@pengutronix.de The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml index 4e3901efed3f..ae6a9fb4f3d0 100644 --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml @@ -49,6 +49,12 @@ patternProperties: $ref: /schemas/usb/usb-device.yaml additionalProperties: true + "^port[1-7]-vbus-supply$" + type: object + description: + Regulator controlling the USB VBUS on portX. Only required if the host + controls the portX VBUS. + allOf: - $ref: usb-device.yaml# - if:
Some PCB designs don't connect the USB hub port power control GPIO and instead make use of a host controllable regulator. Add support for this use-case by introducing portX-vbus-supply property. Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- .../devicetree/bindings/usb/microchip,usb2514.yaml | 6 ++++++ 1 file changed, 6 insertions(+)