diff mbox series

usb: dwc3: Simplify memset struct array

Message ID 20250410-simplify_memset-v1-1-c7bbd850e520@quicinc.com (mailing list archive)
State New
Headers show
Series usb: dwc3: Simplify memset struct array | expand

Commit Message

Zijun Hu April 10, 2025, 1:30 p.m. UTC 
From: Zijun Hu <quic_zijuhu@quicinc.com>

For 'struct property_entry props[6]', Simplify its memset to
'memset(props, 0, sizeof(props))'.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 drivers/usb/dwc3/host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250410-simplify_memset-0ea6dc94a0c7

Best regards,

Comments

Greg Kroah-Hartman April 10, 2025, 5:02 p.m. UTC | #1 
On Thu, Apr 10, 2025 at 09:30:00PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> For 'struct property_entry props[6]', Simplify its memset to
> 'memset(props, 0, sizeof(props))'.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  drivers/usb/dwc3/host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index b48e108fc8fe7343446946e7babf9ba3bc0d2dc3..5a2fe4c6b0e433c32945c136b8b35e1912e3acc8 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -158,7 +158,7 @@ int dwc3_host_init(struct dwc3 *dwc)
>  		goto err;
>  	}
>  
> -	memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));
> +	memset(props, 0, sizeof(props));

What does this really help with?  It feels like churn to me.

thanks,

greg k-h
Zijun Hu April 11, 2025, 12:07 a.m. UTC | #2 
On 2025/4/11 01:02, Greg Kroah-Hartman wrote:
>> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
>> index b48e108fc8fe7343446946e7babf9ba3bc0d2dc3..5a2fe4c6b0e433c32945c136b8b35e1912e3acc8 100644
>> --- a/drivers/usb/dwc3/host.c
>> +++ b/drivers/usb/dwc3/host.c
>> @@ -158,7 +158,7 @@ int dwc3_host_init(struct dwc3 *dwc)
>>  		goto err;
>>  	}
>>  
>> -	memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));
>> +	memset(props, 0, sizeof(props));
> What does this really help with?  It feels like churn to me.

just code in an even more concise way.

for "struct property_entry props[6]", what is your preference to
memset it ?

A) memset(props, 0, sizeof(props));

B) memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));


drivers/usb/* have 5 usages as B).
is it worthy of a patch to simplify them if you prefer A) ?
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index b48e108fc8fe7343446946e7babf9ba3bc0d2dc3..5a2fe4c6b0e433c32945c136b8b35e1912e3acc8 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -158,7 +158,7 @@  int dwc3_host_init(struct dwc3 *dwc)
 		goto err;
 	}
 
-	memset(props, 0, sizeof(struct property_entry) * ARRAY_SIZE(props));
+	memset(props, 0, sizeof(props));
 
 	props[prop_idx++] = PROPERTY_ENTRY_BOOL("xhci-sg-trb-cache-size-quirk");