diff mbox series

[2/5] net: ch9200: remove extraneous return that prevents error propagation

Message ID 20250412183829.41342-3-qasdev00@gmail.com (mailing list archive)
State New
Headers show
Series net: ch9200: fix various bugs and improve qinheng ch9200 driver | expand

Commit Message

Qasim Ijaz April 12, 2025, 6:38 p.m. UTC 
The control_write() function sets err to -EINVAL however there
is an incorrectly placed 'return 0' statement after it which stops
the propogation of the error.

Fix this issue by removing the 'return 0'.

Fixes: 4a476bd6d1d9 ("usbnet: New driver for QinHeng CH9200 devices")
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
 drivers/net/usb/ch9200.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/usb/ch9200.c b/drivers/net/usb/ch9200.c
index 4f29ecf2240a..61eb6c207eb1 100644
--- a/drivers/net/usb/ch9200.c
+++ b/drivers/net/usb/ch9200.c
@@ -168,8 +168,6 @@  static int control_write(struct usbnet *dev, unsigned char request,
 		err = -EINVAL;
 	kfree(buf);
 
-	return 0;
-
 err_out:
 	return err;
 }