diff mbox series

usb: musb: core: drop redundant checks

Message ID 3f8f60d9-f1b5-6b2c-1222-39b156151a22@omp.ru (mailing list archive)
State Accepted
Commit 196a58bdec7c324d6d862cba19069b77ddd48b90
Headers show
Series usb: musb: core: drop redundant checks | expand

Commit Message

Sergey Shtylyov June 18, 2022, 12:06 p.m. UTC
In musb_{save|restore}_context() the expression '&musb->endpoints[i]' just
cannot be NULL, so the checks have no sense at all -- after dropping them,
the local variables 'hw_ep' are no longer necessary, so drop them as well.

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

---
This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.

 drivers/usb/musb/musb_core.c |   16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)
diff mbox series

Patch

Index: usb/drivers/usb/musb/musb_core.c
===================================================================
--- usb.orig/drivers/usb/musb/musb_core.c
+++ usb/drivers/usb/musb/musb_core.c
@@ -2684,13 +2684,7 @@  static void musb_save_context(struct mus
 	musb->context.devctl = musb_readb(musb_base, MUSB_DEVCTL);
 
 	for (i = 0; i < musb->config->num_eps; ++i) {
-		struct musb_hw_ep	*hw_ep;
-
-		hw_ep = &musb->endpoints[i];
-		if (!hw_ep)
-			continue;
-
-		epio = hw_ep->regs;
+		epio = musb->endpoints[i].regs;
 		if (!epio)
 			continue;
 
@@ -2765,13 +2759,7 @@  static void musb_restore_context(struct
 		musb_writeb(musb_base, MUSB_DEVCTL, musb->context.devctl);
 
 	for (i = 0; i < musb->config->num_eps; ++i) {
-		struct musb_hw_ep	*hw_ep;
-
-		hw_ep = &musb->endpoints[i];
-		if (!hw_ep)
-			continue;
-
-		epio = hw_ep->regs;
+		epio = musb->endpoints[i].regs;
 		if (!epio)
 			continue;