| Message ID | 4e785ba5d5e95801b6fcf96116f6090216e70760.1610596478.git.Thinh.Nguyen@synopsys.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 132ee0da6e9f55e6c8b2102a04a5553e20391824 |
| Headers | show |
| Series | usb: dwc3: gadget: Disable Vendor Test LMP Received event | expand |
Hi, Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes: > Some users questioned why Vendor Test LMP Received event was enabled. > The driver currently doesn't handle this event. Let's disable it to > avoid confusion. in case you're curious, it's left-over from early development where we thought we should "enable everything and add code for each one" ;-) > Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Acked-by: Felipe Balbi <balbi@kernel.org>
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index ff14e5bbd152..86f257f12d45 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2232,8 +2232,7 @@ static void dwc3_gadget_enable_irq(struct dwc3 *dwc) u32 reg; /* Enable all but Start and End of Frame IRQs */ - reg = (DWC3_DEVTEN_VNDRDEVTSTRCVEDEN | - DWC3_DEVTEN_EVNTOVERFLOWEN | + reg = (DWC3_DEVTEN_EVNTOVERFLOWEN | DWC3_DEVTEN_CMDCMPLTEN | DWC3_DEVTEN_ERRTICERREN | DWC3_DEVTEN_WKUPEVTEN |
Some users questioned why Vendor Test LMP Received event was enabled. The driver currently doesn't handle this event. Let's disable it to avoid confusion. Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> --- drivers/usb/dwc3/gadget.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) base-commit: 67004e130aafad4c9e0ad3fff9cf67227b6347be