| Message ID | 506f7935-2cba-41d9-ab5d-ddb6ad6320bd@moroto.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0f5aa1b01263b8b621bc4f031a1f2983ef8517b7 |
| Headers | show |
| Series | usb: usbtest: fix a type promotion bug | expand |
diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c index ac0d75ac2d2f..caf65f8294db 100644 --- a/drivers/usb/misc/usbtest.c +++ b/drivers/usb/misc/usbtest.c @@ -705,7 +705,7 @@ static int is_good_config(struct usbtest_dev *tdev, int len) { struct usb_config_descriptor *config; - if (len < sizeof(*config)) + if (len < (int)sizeof(*config)) return 0; config = (struct usb_config_descriptor *) tdev->buf;
The "len" here is sometimes negative error codes from usb_get_descriptor(), so we don't want to type promote them to unsigned long. This bug pre-dates the invention of git. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/usb/misc/usbtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)